Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs link to Setup, Create Repo, Branches, and Admin Pages #2506

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Add docs link to Setup, Create Repo, Branches, and Admin Pages #2506

merged 3 commits into from
Nov 3, 2021

Conversation

DataDavD
Copy link
Contributor

@DataDavD DataDavD commented Oct 3, 2021 •
edited
Loading

This PR adds a documentation link on the Create a New Repository, Initial Setup, Admin, and Branches pages within a lakeFS repo per the
recommendations in Issue 2316.

This PR will close Issue 2316.

@DataDavD DataDavD mentioned this pull request Oct 3, 2021
Closed
itaiad200
itaiad200 requested changes Oct 3, 2021
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DataDavD, thanks for the awesome contribution! See my comment..

webui/src/lib/components/repositoryCreateForm.jsx Outdated Show resolved Hide resolved
@DataDavD
Copy link
Contributor Author

DataDavD commented Oct 7, 2021 •
edited
Loading

Sorry for the spam @itaiad200 (still getting used to using Github in a collaborative manner 😸 ). Anyways, I posted some screenshot with the changes. I figure there still needs to be some changes, but I wanted to make sure with you that this is on the right track.

Also, do you or anyone else (i.e. PM, PMM, comms, etc) at lakeFS/treeverse want to review the wording in the links?

Let me know. If so, then I'll finalize the wording and such and rebase the commits as one and click ready for review on this PR.

Thanks again for all your help!

best,
david

@DataDavD DataDavD changed the title Add doc link to Create a New Repo form Add docs link to Setup, Create Repo, Branches, and Admin Pages Oct 7, 2021
itaiad200
itaiad200 requested changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments. I think this PR will benefit from extra set of eyes, preferably with more UX experience. @johnnyaug , can you take a glance?

webui/src/lib/components/auth/layout.jsx Outdated Show resolved Hide resolved
webui/src/pages/repositories/repository/branches.jsx Outdated Show resolved Hide resolved
webui/src/pages/setup/index.jsx Outdated Show resolved Hide resolved
@johnnyaug
Copy link
Contributor

Hey @DataDavD! Thank you for your contribution.
This user experience is very important in this issue, and this includes precision in small things like phrasing and alignments.
I have created mock-ups for this issue, can you please follow them?

Thanks again for your effort!

@DataDavD
Copy link
Contributor Author

Thanks @johnnyaug, this is exactly the support/direction I needed. I'm working on this now to get it updated

@DataDavD DataDavD requested a review from itaiad200 October 14, 2021 09:53
@itaiad200 itaiad200 added the include-changelog PR description should be included in next release changelog label Nov 2, 2021
@DataDavD DataDavD force-pushed the fix/ddansby/link-docs-to-webui-2316 branch from ab5d347 to 4faf7bc Compare November 2, 2021 12:36
@DataDavD
Issue 2316 Add doc links to webui
d9fbaf0 
This commit adds doc links in the Create a Repo, Admin, Initial Setup,
and Branches pages. It does this by simply adding hyperlink tag in the
appropriate React components and pages. These hyperlink open a new tag
and includes the rel="noopener noreferrer" attribute values.

The "Learn more." text has been added to accordingly based on the mocks
referenced in Issue 2316
(treeverse#2316).
@DataDavD DataDavD force-pushed the fix/ddansby/link-docs-to-webui-2316 branch from 4faf7bc to d9fbaf0 Compare November 2, 2021 12:42
@DataDavD
Merge branch 'master' of https://github.com/treeverse/lakeFS into fix…
b946373 
…/ddansby/link-docs-to-webui-2316

� Conflicts:
�	webui/src/styles/globals.css
@DataDavD DataDavD marked this pull request as ready for review November 2, 2021 12:57
@DataDavD
Copy link
Contributor Author

DataDavD commented Nov 2, 2021

@itaiad200 FYI this PR is (finally) ready for review. Here are the corresponding screenshots from these updated changes.

cc @johnnyaug just in case you wanna review these versus the mocks you provided.

Thanks again for the patience and directional help.

Screen Shot 2021-11-02 at 5 51 42 AM
Screen Shot 2021-11-02 at 5 51 39 AM
Screen Shot 2021-11-02 at 5 51 36 AM
Screen Shot 2021-11-02 at 5 51 32 AM
Screen Shot 2021-11-02 at 5 51 27 AM
Screen Shot 2021-11-02 at 5 51 10 AM
Screen Shot 2021-11-02 at 5 51 01 AM

itaiad200
itaiad200 requested changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @DataDavD, we're almost there!

webui/src/pages/repositories/index.jsx Outdated Show resolved Hide resolved
webui/src/pages/auth/credentials.jsx Outdated Show resolved Hide resolved
@itaiad200
Copy link
Contributor

@itaiad200 FYI this PR is (finally) ready for review. Here are the corresponding screenshots from these updated changes.

cc @johnnyaug just in case you wanna review these versus the mocks you provided.

Thanks again for the patience and directional help.

Screen Shot 2021-11-02 at 5 51 42 AM Screen Shot 2021-11-02 at 5 51 39 AM Screen Shot 2021-11-02 at 5 51 36 AM Screen Shot 2021-11-02 at 5 51 32 AM Screen Shot 2021-11-02 at 5 51 27 AM Screen Shot 2021-11-02 at 5 51 10 AM Screen Shot 2021-11-02 at 5 51 01 AM

@DataDavD I think we're ready to close this PR once you wrap up the last two comments I added yesterday. Again - thank you very much for this contribution :)

@DataDavD
Copy link
Contributor Author

DataDavD commented Nov 3, 2021

@itaiad200 done with your requested changes (see screenshots below). Please let me know if there is anything else I need to do.

Once again thank you (and @johnnyaug and @nopcoder) for all the help. Really appreciate your assistance.
Screen Shot 2021-11-03 at 1 44 34 AM
Screen Shot 2021-11-03 at 1 44 31 AM
Screen Shot 2021-11-03 at 1 44 27 AM
Screen Shot 2021-11-03 at 1 44 25 AM
Screen Shot 2021-11-03 at 1 44 08 AM
Screen Shot 2021-11-03 at 1 43 59 AM
Screen Shot 2021-11-03 at 1 43 07 AM
Screen Shot 2021-11-03 at 1 42 55 AM

itaiad200
itaiad200 approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks @DataDavD

@DataDavD
Copy link
Contributor Author

DataDavD commented Nov 3, 2021

Awesome @itaiad200, thank you.

I know its small, but this frontend stuff humbled me. However, it was a good humbling as I was able to expand my knowledge of React.

I'm going to start working on #2415 now.

Thanks again!

Best,
David

@itaiad200 itaiad200 merged commit d7efbf7 into treeverse:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyaug johnnyaug johnnyaug left review comments

@itaiad200 itaiad200 itaiad200 approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DataDavD @johnnyaug @itaiad200