-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document view #246
Comments
@taramk pushed initial poc to play with and iterate. does not use codemirror yet. node (block?) menu positioning could be adjusted. no support for bulleted lists or headers or anything yet, just paragraphs. type a node then run command "Make Document". it will take you to the document (should prob focus on new node placeholder). going back out, the document node has a document icon. clicking it takes you to the document instead of expanding. |
@progrium do we plan to integrate codemirror this sprint or is that later? is there anything else you are planning to do right now, or are you waiting for feedback? |
CodeMirror and minor improvements from here I was hoping to do tomorrow with any other feedback or bugs/issues we find. |
@progrium - won't codemirror introduce different style/behavior changes? i'd rather do the bulk of QA when that's in, since i'm not sure exactly what effects it will have |
|
I think Document, like Smart Node, are going to be one-way operations. "Make X" as opposed to "View as X". It does too much to the node. Plus think if document nodes have formatting from CodeMirror, they would show up as raw markdown as list nodes, and who knows what else. But unlike Smart Nodes that are supposed to be made for multiple views, Documents should not have the option to change their view. You also can't expand the document inline, or rather if we did the text would be centered and not look right. So then the node icon becomes useless interaction wise. Alternatively the text could be a link, but then you'd have to make sure not to click the text when you want to edit the title. "Open" is already in the node menu, but I think the nature of documents taking the whole panel it should be quicker to get there. |
A view like Notion.
Nodes:
The text was updated successfully, but these errors were encountered: