Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document view #246

Closed
7 tasks done
progrium opened this issue Jul 7, 2023 · 6 comments
Closed
7 tasks done

Document view #246

progrium opened this issue Jul 7, 2023 · 6 comments
Assignees
Labels
critical a blocker or other very important item enhancement New feature or request
Milestone

Comments

@progrium
Copy link
Contributor

progrium commented Jul 7, 2023

A view like Notion.

Nodes:

  • lose their bullet
  • have menu
  • are centered w/ auto left and right margin (might not do that inline)
  • node children might be hidden w/ a link - need to test both ways
  • basic style changes
  • header style change
  • document component
  • make document command
  • special icon
  • hide children
  • starmirror
@progrium progrium added this to the 0.6.0 milestone Jul 7, 2023
@progrium progrium self-assigned this Jul 7, 2023
@taramk taramk added enhancement New feature or request critical a blocker or other very important item labels Jul 10, 2023
@progrium
Copy link
Contributor Author

@taramk pushed initial poc to play with and iterate. does not use codemirror yet. node (block?) menu positioning could be adjusted. no support for bulleted lists or headers or anything yet, just paragraphs. type a node then run command "Make Document". it will take you to the document (should prob focus on new node placeholder). going back out, the document node has a document icon. clicking it takes you to the document instead of expanding.

@taramk
Copy link
Contributor

taramk commented Jul 12, 2023

@progrium do we plan to integrate codemirror this sprint or is that later? is there anything else you are planning to do right now, or are you waiting for feedback?

@progrium
Copy link
Contributor Author

CodeMirror and minor improvements from here I was hoping to do tomorrow with any other feedback or bugs/issues we find.

@taramk
Copy link
Contributor

taramk commented Jul 12, 2023

@progrium - won't codemirror introduce different style/behavior changes? i'd rather do the bulk of QA when that's in, since i'm not sure exactly what effects it will have

@taramk
Copy link
Contributor

taramk commented Jul 12, 2023

  • if i make it a document then make it a list again, it still has the document icon (but clicking it opens it in list view)
  • i don't love the idea of using the document icon that way, since it breaks our established pattern of what the node icon is supposed to do. is there a way we can keep the established behavior (click icon to expand/collapse content) and also have a shortcut to the document view? put it in the node menu maybe?

@progrium
Copy link
Contributor Author

I think Document, like Smart Node, are going to be one-way operations. "Make X" as opposed to "View as X". It does too much to the node. Plus think if document nodes have formatting from CodeMirror, they would show up as raw markdown as list nodes, and who knows what else. But unlike Smart Nodes that are supposed to be made for multiple views, Documents should not have the option to change their view.

You also can't expand the document inline, or rather if we did the text would be centered and not look right. So then the node icon becomes useless interaction wise. Alternatively the text could be a link, but then you'd have to make sure not to click the text when you want to edit the title. "Open" is already in the node menu, but I think the nature of documents taking the whole panel it should be quicker to get there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical a blocker or other very important item enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants