Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make paths for zip files identical on different OS: macOS and Windows #79

Merged
merged 4 commits into from
Jan 16, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Jan 15, 2022

This PR…

closes #75

  • the zip created with macOS does not include full path in zip file
  • the zip created with Windows does not include country folder in zip file
  • with this, the created zips are identical with both OS macOS and Windows

Considerations and implementations

see #75 for comparison

zip for malta using macOS
grafik

zip for malta using Windows
image

How to test

  1. checkout this branch git checkout fix-zip-paths-to-be-identical
  2. create any map, e.g. of malta
  3. extract the generated zips
  4. check folder structure of unzipped folder

Pull Request Checklist

@treee111 treee111 changed the title FIX Make paths for zip files identical on different OS: macOS and Windows [FIX] Make paths for zip files identical on different OS: macOS and Windows Jan 15, 2022
@treee111 treee111 force-pushed the develop branch 6 times, most recently from 70496a2 to 99d9102 Compare January 15, 2022 20:59
@treee111 treee111 merged commit 85c8a36 into develop Jan 16, 2022
@treee111 treee111 deleted the fix-zip-paths-to-be-identical branch January 16, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path for zip files is not identical on different OS
1 participant