-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Support osmosis-tool v1.13.2 by sorting land* osm files before merging #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treee111
force-pushed
the
adjustments-for-osmosis-tool-v1.13.2
branch
from
January 13, 2022 22:03
56e9320
to
b5e244d
Compare
treee111
changed the title
Adjustments for osmosis tool v1.13.2
[FEATURE] Support osmosis-tool v1.13.2 by sorting land* osm files before merging
Jan 13, 2022
- adoption of 8f1e46b
- Osmosis is only used in Windows. macOS uses osmium-tool - three ocurrences of the path were replaced
treee111
changed the title
[FEATURE] Support osmosis-tool v1.13.2 by sorting land* osm files before merging
[FIX] Support osmosis-tool v1.13.2 by sorting land* osm files before merging
Jan 15, 2022
macdet
approved these changes
Jan 15, 2022
macdet
approved these changes
Jan 15, 2022
macdet
approved these changes
Jan 15, 2022
treee111
added a commit
that referenced
this pull request
Jan 15, 2022
…before merging (#78) - sorts land*.osm files to be in this order: nodes, then ways, then relations. - for osmium-merge of the osmium-tool on macOS, this is mandatory since https://github.com/osmcode/osmium-tool/releases/tag/v1.13.2 * fix lint findings in shape2osm.py - new version is from https://github.com/mapsforge/mapsforge-creator/blob/master/shape2osm.py * sort land* osm files before merging closes #77 * extract output dir for tile to variable * sort land* osm files before merging on Windows - adoption of 8f1e46b * move Osmosis to tooling_windows & extract path to file to variable - Osmosis is only used in Windows. macOS uses osmium-tool - three ocurrences of the path were replaced
treee111
added a commit
that referenced
this pull request
Jan 17, 2022
- #78 - Updated GDAL from 3.0.2 to 3.4.1 and other packages as well
treee111
added a commit
that referenced
this pull request
Jan 18, 2022
- #78 - Updated GDAL from 3.0.2 to 3.4.1 and other packages as well
4 tasks
treee111
added a commit
that referenced
this pull request
Jan 18, 2022
…aconda environment (#83) - updates the output files to compare against for malta and liechtenstein - files created in /conda_env/developer.yml Anaconda environment from #82 - land* osm files changed by #78 * update test-files to new setup on macOS - #78 - Updated GDAL from 3.0.2 to 3.4.1 and other packages as well * update test-files to new setup on Windows - #78 - Updated GDAL from 3.0.2 to 3.4.1 and other packages as well
treee111
added a commit
that referenced
this pull request
Jan 19, 2022
…rpening Anaconda environment (#83) - updates the output files to compare against for malta and liechtenstein - files created in /conda_env/developer.yml Anaconda environment from #82 - land* osm files changed by #78 * update test-files to new setup on macOS - #78 - Updated GDAL from 3.0.2 to 3.4.1 and other packages as well * update test-files to new setup on Windows - #78 - Updated GDAL from 3.0.2 to 3.4.1 and other packages as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
closes #77
Considerations and implementations
see issue #77 for more details
How to test
Pull Request Checklist