Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Fix unittests #222

Merged
merged 4 commits into from
Nov 4, 2023
Merged

[DEV] Fix unittests #222

merged 4 commits into from
Nov 4, 2023

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Nov 3, 2023

This PR…

fixes the unittests. Unittests have not been checked locally for some time and thus are not working due to latest changes. These are the three things they are failing on 02.11.2023:

  1. more OSM elements are included in the tags-to-keep.json but are not in the hardcoded list to check against in the unittests - fixed by bf8f0d6
  2. corrects including elevation data into the maps. If elevation data was present per tile (from a run earlier), they are included into the generated maps even if not requested - i.e. -con is not given. That makes the generated files from unittests differ from the static files in the repo because they are not generated with elevation data. Fixed by 1a24bdb, already fixed by [FIX] include elevation data only if requested by the user, i.e. if -con is given #223
  3. adds new static files to check against for macOS and Windows to have the newly added OSM elements in the static files to check against - fixed by d39a6d4

Considerations and implementations

This is the main body of the PR, and varies massively by PR. A simple PR may have a single sentence here, others may have multiple paragraphs, diagrams, etc.

{...}

How to test

  1. setup unittests
  2. run unittests under macOS and Windows

Pull Request Checklist

@treee111 treee111 mentioned this pull request Nov 3, 2023
1 task
treee111 and others added 3 commits November 3, 2023 09:05
- due to changes in included OSM elements from #206 b8f4d16 and #201 f6a4b99
- plus adding 100/137 as this was not inclued before in Windows, but in macOS
- due to changes in included OSM elements from #206 b8f4d16 and #201 f6a4b99
@treee111 treee111 added the infrastructure Infrastructure label Nov 3, 2023
@alfh
Copy link
Contributor

alfh commented Nov 3, 2023

I can confirm that the unit tests in this branch runs OK on my linux machine as well, using the zip file for the land polygon that you provided in pr #220

Here is the output
Ran 58 tests in 47.216s

So I guess pr 220 can be cancelled, and this one merged then.

- incl. refactoing the file & link to land-poligons
- remove not needed headlines
@treee111
Copy link
Owner Author

treee111 commented Nov 4, 2023

I can confirm that the unit tests in this branch runs OK on my linux machine as well, using the zip file for the land polygon that you provided in pr #220

Here is the output Ran 58 tests in 47.216s

So I guess pr 220 can be cancelled, and this one merged then.

thanks for confirming 👍

I added the documentation for unittests with ee48c82

@treee111 treee111 merged commit 04f09ac into develop Nov 4, 2023
@treee111 treee111 deleted the fix-unittests branch November 4, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants