[BREAKING] X/Y input via geofabrik .json + only support processing maps via geofabrik .json, delete wahoomc/resources/json/ files, constants and related coding
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lines 156-167 + 370-382 in geofabrik might not be needed / to be discussed
treee111
force-pushed
the
geofabrik-xy
branch
3 times, most recently
from
59abfac to
ff4a8ff
Compare
- reduce methods in geofabrik.py by using GeofabrikJson Ckass - add geometry to geofabrik_overview dict + getter
- calc. all x/y tiles in one run - identical to country
treee111
force-pushed
the
geofabrik-xy
branch
from
ff4a8ff to
0a1b6a7
Compare
… tiles some unittests did make sense to do them via geofabrik
for CLI and UI
treee111
force-pushed
the
geofabrik-xy
branch
from
0a1b6a7 to
7ada604
Compare
treee111
changed the title
wahoomc/resources/json and only use geofabrik .json for constantswahoomc/resources/json/ files, constans and related coding
treee111
force-pushed
the
geofabrik-xy
branch
from
7ada604 to
707c70f
Compare
treee111
force-pushed
the
geofabrik-xy
branch
from
707c70f to
90b8657
Compare
treee111
changed the title
wahoomc/resources/json/ files, constans and related codingwahoomc/resources/json/ files, constans and related coding
treee111
changed the title
wahoomc/resources/json/ files, constans and related codingwahoomc/resources/json/ files, constants and related coding
treee111
added a commit
that referenced
this pull request
May 5, 2023
…ps via geofabrik .json, delete `wahoomc/resources/json/` files, constants and related coding (#183) * only read geofabrik file once + make "global" variable * x/y coordinates working solution lines 156-167 + 370-382 in geofabrik might not be needed / to be discussed * unittest * translate to and set geofabrik id_no if found * reduce complexity - reduce methods in geofabrik.py by using GeofabrikJson Ckass - add geometry to geofabrik_overview dict + getter * mode in Geofabrik class, get unittests to work again - calc. all x/y tiles in one run - identical to country * Geofabrik as interface and two classes * cut geofabrik.py into functions, detailled unittests * pylint and vulture findings + delete one dir more * delete existing .json files implementation + unittests for retrieving tiles some unittests did make sense to do them via geofabrik * remove geofabrik_tiles input argument for CLI and UI * clean up launch configuration, comments * PR review findings * files of unittest run on macOS for malta 2. tile (geofabrik) BREAKING CHANGE: Processing is now only based on Geofabrik .json file which is downloaded both for country and X/Y input. The static country .json files and the whole implementation has been removed. `-gt` input argument was also removed because there is only one processing method implemented. Input should now be in Geofabrik style. The hardcoded translation to geofabrik countries has been removed. The size of generated maps for X/Y coordinates should remain exactly the same as before. The size of generated maps for countries should roughly be the same as before.
alfh
pushed a commit
to alfh/wahooMapsCreator
that referenced
this pull request
Nov 4, 2023
…ps via geofabrik .json, delete `wahoomc/resources/json/` files, constants and related coding (treee111#183) * only read geofabrik file once + make "global" variable * x/y coordinates working solution lines 156-167 + 370-382 in geofabrik might not be needed / to be discussed * unittest * translate to and set geofabrik id_no if found * reduce complexity - reduce methods in geofabrik.py by using GeofabrikJson Ckass - add geometry to geofabrik_overview dict + getter * mode in Geofabrik class, get unittests to work again - calc. all x/y tiles in one run - identical to country * Geofabrik as interface and two classes * cut geofabrik.py into functions, detailled unittests * pylint and vulture findings + delete one dir more * delete existing .json files implementation + unittests for retrieving tiles some unittests did make sense to do them via geofabrik * remove geofabrik_tiles input argument for CLI and UI * clean up launch configuration, comments * PR review findings * files of unittest run on macOS for malta 2. tile (geofabrik) BREAKING CHANGE: Processing is now only based on Geofabrik .json file which is downloaded both for country and X/Y input. The static country .json files and the whole implementation has been removed. `-gt` input argument was also removed because there is only one processing method implemented. Input should now be in Geofabrik style. The hardcoded translation to geofabrik countries has been removed. The size of generated maps for X/Y coordinates should remain exactly the same as before. The size of generated maps for countries should roughly be the same as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
constants.pyandwahoomc/resources/json) #182, input is now interpreted and processed only via geofabrik so the-gtargument is not existing anymore as geofabrik processing is the only optionwahoomc/resources/json/and only processes maps using geofabrik .json and all python coding which deals with getting these .json filesConsiderations and implementations
Geofabrik (.py) class is now refactored into a interface and two implementing classes. Furthermore, the coding is cut into smaller functions a little bit.
find_needed_countriesis still a kind of mystery ;-)Branch
geofabrik-xy-unittestsbrings in unittests for geofabrik tiles to compare static vs. geofabrik processing and can be used also in the future.The size of generated maps for X/Y coordinates should remain exactly the same as before. The size of generated maps for countries should roughly be the same as before (germany 604MB vs 607MB).
How to test
Pull Request Checklist