Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more optimizations #146

Closed
wants to merge 0 commits into from
Closed

Conversation

zenziwerken
Copy link
Contributor

This PR

adds a few more tags to 'constants.py' and 'tag-wahoo.xml' according to the upodated 'Bolt2-Mapsforge-Rendertheme'

Pull Request Checklist

@zenziwerken zenziwerken changed the title Some more optimazations Some more optimizations Sep 21, 2022
@treee111 treee111 reopened this Sep 25, 2022
@treee111
Copy link
Owner

Hi @zenziwerken,
thanks for this PR! Looks promising 👍

Could we please separate the wahoomc/osm_maps_functions.py processing changes from the others and issue a new pull request therefore? The CHANGELOG is created based on pull requests names and thus separating changes is helpful.

You could do this by creating a new branch from your develop and delete not needed commits like described here: https://www.w3docs.com/snippets/git/deleting-commits-from-a-branch-in-git.html#deleting-a-commit-in-the-middle-of-the-history-14

Thanks!

@treee111
Copy link
Owner

treee111 commented Sep 26, 2022

Hi @zenziwerken, thanks for this PR! Looks promising 👍

Could we please separate the wahoomc/osm_maps_functions.py processing changes from the others and issue a new pull request therefore? The CHANGELOG is created based on pull requests names and thus separating changes is helpful.

You could do this by creating a new branch from your develop and delete not needed commits like described here: https://www.w3docs.com/snippets/git/deleting-commits-from-a-branch-in-git.html#deleting-a-commit-in-the-middle-of-the-history-14

Thanks!

I've done that now because I am in kind of a rush actually :-D
It's this PR here and #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants