[FEATURE] Check for required programs at wahooMapsCreator start #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treee111
changed the title
treee111
force-pushed
the
check-required-programs
branch
2 times, most recently
from
a3d8d03 to
5546c3f
Compare
treee111
force-pushed
the
check-required-programs
branch
from
5546c3f to
a82abfb
Compare
treee111
force-pushed
the
check-required-programs
branch
6 times, most recently
from
ec4f0d9 to
1cfee3a
Compare
treee111
force-pushed
the
check-required-programs
branch
2 times, most recently
from
4f38727 to
3f62049
Compare
treee111
force-pushed
the
check-required-programs
branch
from
3f62049 to
b7ca9b1
Compare
treee111
added a commit
that referenced
this pull request
Oct 30, 2022
* implement check for required programs for macOS - incl. unittests * move get_tooling_win_path to constants_functions * implement check for required programs for Windows - incl. unittests * adjustments after testing on Windows. Extension needed * verbose output for osmium processing * catch error if no file exists in plugins directory * format terminal output when checking for required programs * move get_tag_wahoo_xml_path to constants_functions to be identical with changes from eab0345 * Revert "verbose output for osmium processing" This reverts commit a700f68. It is not working as intended on macOS // not outputting something. Most likely because of the "subprocess.Popen" stlye of calling the command * Bump to version v2.1.0a15
treee111
added a commit
that referenced
this pull request
Oct 30, 2022
* implement check for required programs for macOS - incl. unittests * move get_tooling_win_path to constants_functions * implement check for required programs for Windows - incl. unittests * adjustments after testing on Windows. Extension needed * verbose output for osmium processing * catch error if no file exists in plugins directory * format terminal output when checking for required programs * move get_tag_wahoo_xml_path to constants_functions to be identical with changes from eab0345 * Revert "verbose output for osmium processing" This reverts commit a700f68. It is not working as intended on macOS // not outputting something. Most likely because of the "subprocess.Popen" stlye of calling the command * Bump to version v2.1.0a15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
Considerations and implementations
How to test
Install wahoomc in alpha version 2.1.0a15 via
pip install wahoomc==2.1.0a15After testing you can revert to the lates published version via
pip install wahoomc==2.0.2Pull Request Checklist