Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] country & regions constants and mapping #113

Merged
merged 6 commits into from
May 2, 2022
Merged

[FIX] country & regions constants and mapping #113

merged 6 commits into from
May 2, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented May 1, 2022 •
edited
Loading

This PR…

Considerations and implementations

How to test

  1. run tool for mexico

Pull Request Checklist

@treee111 treee111 added the bug Something isn't working label May 1, 2022
@treee111 treee111 force-pushed the fix-country-regions-constants branch from da1aeae to 602035e Compare May 1, 2022 21:31
treee111 added 6 commits May 2, 2022 00:02
@treee111
correct contries/region constants and mapping
5823dd9 
- correct countries per region in constants.py and constants_functions.py
- introduce new function to get path of static tile .json file
- use new function
@treee111
unittests for country/region constants and mapping
4000352
@treee111
cherry pick folder functions
9e40e39 
- from dabe117
@treee111
launch config for mexico
86a468f
@treee111
introducing northamerica_us geofabrik
5e2a7ca 
- for processing "mexico -bc"
- california etc. have not been able to download
@treee111
mapping for new_mexico and function to build url (unittesting!)
0af136d
@treee111 treee111 force-pushed the fix-country-regions-constants branch 2 times, most recently from f55d7d0 to 0af136d Compare May 2, 2022 18:21
@treee111 treee111 changed the base branch from develop to release-v1.1.1 May 2, 2022 18:36
@treee111 treee111 merged commit e45d89c into release-v1.1.1 May 2, 2022
@treee111 treee111 deleted the fix-country-regions-constants branch May 2, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path of static .json file of Mexico is not correct
1 participant
@treee111