-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bindings for 0.24 #259
Conversation
0fa49a2
to
cd9d157
Compare
I'll leave it to you to fix the failing file @calebdw :) |
Issue is that unary op expressions (-1) aren't supported in enums yet, I'll send a fix. By the way, would it be possible to update the parse action to show any failed files up front? It's kind of a pain to have to scroll through miles of lines to see which one failed https://github.com/tree-sitter/tree-sitter-php/actions/runs/11339991148/job/31535650336 |
Ah 🤣 that would've helped. |
Do we no longer run the local tests in ci? It looks like we just parse example files (Sorry for deleting your comment---it came through twice on my end so I tried to clean up the duplicate and now it looks like none survived 😬) |
Hm what do you mean by the local tests? iirc And no worries, I was on mobile with poor connection so it sent twice |
Ah, I see it now, it was nested in between the clones and I skipped over it thinking it was the example parsing: - name: Run tests
uses: tree-sitter/parser-test-action@v2
with:
test-rust: true
test-node: true
test-python: true
test-go: true
test-swift: true Everything looks good to me, thanks for all your hard work on tree-sitter! I love the more frequent releases :) |
Do you know why node v23 isn't downloading? https://github.com/tree-sitter/tree-sitter-php/actions/runs/11348329979/job/31562460626 |
Namely: