Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stdlib calls: isxdigit -> iswxdigit, wcscmp -> memcmp #220

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

maxbrunsfeld
Copy link
Contributor

This PR change the external scanner to use the standard set of libc functions defined in tree-sitter/tree-sitter#2897, which will make it possible to consume these parsers as WASM files.

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (x new conflicts)
  • The parser size hasn't grown too much (master: STATE_COUNT, PR: STATE_COUNT)
    (check the value of STATE_COUNT in src/parser.c)

@amaanq
Copy link
Member

amaanq commented Feb 5, 2024

Nice, thanks!

@amaanq amaanq merged commit 5ceb923 into master Feb 5, 2024
4 checks passed
@maxbrunsfeld maxbrunsfeld deleted the common-stdlib-functions branch February 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants