Revert binding changes #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c423bcc, there were again made some changes to master without PR, for which I don't understand the reasoning.
.gitattributes
The tree-sitter src files are vendored, not generated. It's a small difference, but it's not the same.
Almost all the binding code might have been based on generated templates, but they're manually edited because this is a multi-grammar repo. So they're not
linguist-generated..gitignore
The examples directory should not be ignored. If an example submodule is updated, that's a change that should be committed.
READMEs
I created custom READMEs for Python and Rust, which are used on https://pypi.org/project/tree-sitter-ocaml/ https://crates.io/crates/tree-sitter-ocaml. I don't know why they were removed. Now these pages are showing nodejs information again instead of correct documentation and example code.