Support OCaml 5.3 #101
Merged
Support OCaml 5.3 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we can't even review the PR ... github says the files are too big ... |
|
I don't know what's happening at Github, but I've seen that a lot lately. In the past, only the diffs of the big files would be hidden, especially if they're marked as |
|
I moved the changes to generated files to a separate commit, so the other commits can be reviewed on Github. |
aryx
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unicode handling is more relaxed than actual OCaml. Accepting exactly the same identifiers would make the grammar a lot more complicated (and slow).
Handling unicode in the external scanner (e.g. distinguishing lowercase and uppercase characters) is almost impossible without introducing external dependencies. So the external scanner is even more relaxed in accepting quoted string identifiers.