Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): iterate over captures for the shortest size, not longest #309

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Oct 24, 2024

Closes #308

Problem

The condition for iterating in satisfies_eq_capture was wrong, it should not iterate for whichever amount between the length of the first node array and the length of the second node array is larger. It should take the shortest length, since both must be valid.

Solution

In the condition, set l to the shortest number between size1 and size2. This mimics the Rust code here

@ObserverOfTime ObserverOfTime merged commit 78d558f into master Oct 24, 2024
15 checks passed
@ObserverOfTime ObserverOfTime deleted the segfault-query branch October 24, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation Fault in node_get_text
2 participants