binding/query.c: use PyErr_Format instead of _PyErr_FormatFromCause #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_PyErr_FormatFromCause` function is a private function, which was never documented. While it existed for a long time, it was removed in Python 3.13 [1]. Use instead the public function `PyErr_Format`, which is also part of the stable API. [1] python/cpython#106320 Signed-off-by: Arthur Zamarin <[email protected]>
Signed-off-by: Arthur Zamarin <[email protected]>
|
|
OK, so which other function should we use? I can modify it as needed. |
|
It's complicated. I'll look into it during the weekend. |
|
Thank you. I leave it to your discretion if you want to just close this PR, or override it, or anything else. |
|
Fixed in 2f7889d |
|
@ObserverOfTime any chance cutting a new release? Thanks! |
|
It's in v0.23.1. |
|
sorry, I missed it, the 0.23.1 works for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_PyErr_FormatFromCausefunction is a private function, which was never documented. While it existed for a long time, it was removed in Python 3.13 python/cpython#106320.Use instead the public function
PyErr_Format, which is also part of the stable API.