-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update retryable errors in unit tests #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuokada
changed the title
Adopt exponential retry interval in test
Adopt exponential retry interval in test and so on
Sep 29, 2022
yuokada
force-pushed
the
retry-interval
branch
from
September 29, 2022 05:40
d6363ac
to
e8878f6
Compare
yuokada
changed the title
Adopt exponential retry interval in test and so on
Update retryable errors and so on
Sep 29, 2022
yuokada
changed the title
Update retryable errors and so on
Update retryable errors in test and so on
Sep 29, 2022
yuokada
changed the title
Update retryable errors in test and so on
Update retryable errors in unit tests
Sep 29, 2022
yuokada
commented
Sep 29, 2022
@@ -21,7 +21,8 @@ | |||
|
|||
MAX_RETRY_COUNT = 5 | |||
RETRYABLE_ERRORS = [ | |||
/No nodes available to run query/ | |||
/No nodes available to run query/, | |||
/failed: nodes is empty/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g: https://github.com/treasure-data/trino-client-ruby/actions/runs/3148838251/jobs/5119794338
Failures:
1) Trino::Client::Client tpch q01 with gzip option
Failure/Error: columns, rows = run_with_retry(@client, q)
RuntimeError:
Fail to run query: Query 20220929_052531_00003_zcvyz failed: nodes is empty
# ./spec/gzip_spec.rb:32:in `block (2 levels) in <top (required)>'
2) Trino::Client::Client q01
Failure/Error: columns, rows = run_with_retry(@client, q)
RuntimeError:
Fail to run query: Query 20220929_052556_00003_4bg55 failed: nodes is empty
# ./spec/tpch_query_spec.rb:30:in `block (2 levels) in <top (required)>'
takezoe
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
exoego
added
enhancement
chore
non user-facing trivial stuff (CI, refactoring, etc)
and removed
enhancement
labels
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolve CI failure happening lately
Overview
Checklist