Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retryable errors in unit tests #77

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Update retryable errors in unit tests #77

merged 2 commits into from
Sep 29, 2022

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Sep 29, 2022

Purpose

Resolve CI failure happening lately

Overview

  • Adopt exponential interval in retry
  • Update retryable errors

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@yuokada yuokada requested a review from a team as a code owner September 29, 2022 05:04
@yuokada yuokada changed the title Adopt exponential retry interval in test Adopt exponential retry interval in test and so on Sep 29, 2022
@yuokada yuokada changed the title Adopt exponential retry interval in test and so on Update retryable errors and so on Sep 29, 2022
@yuokada yuokada changed the title Update retryable errors and so on Update retryable errors in test and so on Sep 29, 2022
@yuokada yuokada changed the title Update retryable errors in test and so on Update retryable errors in unit tests Sep 29, 2022
@@ -21,7 +21,8 @@

MAX_RETRY_COUNT = 5
RETRYABLE_ERRORS = [
/No nodes available to run query/
/No nodes available to run query/,
/failed: nodes is empty/
Copy link
Contributor Author

@yuokada yuokada Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g: https://github.com/treasure-data/trino-client-ruby/actions/runs/3148838251/jobs/5119794338

Failures:

  1) Trino::Client::Client tpch q01 with gzip option
     Failure/Error: columns, rows = run_with_retry(@client, q)
     RuntimeError:
       Fail to run query: Query 20220929_052531_00003_zcvyz failed: nodes is empty
     # ./spec/gzip_spec.rb:32:in `block (2 levels) in <top (required)>'

  2) Trino::Client::Client q01
     Failure/Error: columns, rows = run_with_retry(@client, q)
     RuntimeError:
       Fail to run query: Query 20220929_052556_00003_4bg55 failed: nodes is empty
     # ./spec/tpch_query_spec.rb:30:in `block (2 levels) in <top (required)>'

Copy link
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@takezoe takezoe merged commit cfd99f6 into master Sep 29, 2022
@yuokada yuokada mentioned this pull request Sep 29, 2022
4 tasks
@yuokada yuokada deleted the retry-interval branch September 29, 2022 06:03
@exoego exoego added enhancement chore non user-facing trivial stuff (CI, refactoring, etc) and removed enhancement labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore non user-facing trivial stuff (CI, refactoring, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants