Include system memory to StatementStats #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
reviewed
Feb 9, 2022
| @@ -618,7 +618,7 @@ private static StatementStats toStatementStats(QueryInfo queryInfo) | |||
| .setElapsedTimeMillis(queryStats.getElapsedTime().toMillis()) | |||
| .setProcessedRows(queryStats.getRawInputPositions()) | |||
| .setProcessedBytes(queryStats.getRawInputDataSize().toBytes()) | |||
| .setPeakMemoryBytes(queryStats.getPeakUserMemoryReservation().toBytes()) | |||
| .setPeakMemoryBytes(queryStats.getPeakUserMemoryReservation().toBytes() + queryStats.getPeakNonRevocableMemoryReservation().toBytes()) | |||
There was a problem hiding this comment.
getPeakNonRevocableMemoryReservation() was added in 337: trinodb@11b7d19
There was a problem hiding this comment.
I've changed it to getPeakTotalMemoryReservation here. As we don't use evocableMemory (spill), the values will be the same. In 350, we can use getPeakNonRevocableMemoryReservation.
miniway
force-pushed
the
system_memory
branch
from
5b8c20b to
90c8d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Trino 369, it will not separate user and system memories trinodb#10574 . So it should be fine to include system memory to StatementStats as a workaround