Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option node_modules for node.js builds #1263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BanzaiMan
Copy link
Contributor

To turn off manipulating $PATH

See travis-ci/travis-ci#8813, travis-ci/travis-ci#5092.

To turn off manipulating `$PATH`
@BanzaiMan
Copy link
Contributor Author

The option node_modules is probably too vague. Maybe node_modules_bin_in_path, though this may be too long.

@ankon
Copy link
Contributor

ankon commented Aug 3, 2018

Anything we can help with to get this forward?

@joshk
Copy link
Contributor

joshk commented Aug 3, 2018

Thanks for the ping. I'll have a look into this next week.

@joshk
Copy link
Contributor

joshk commented Aug 5, 2018

I'm sorry, I'll need a little longer to look into this as I wanted to talk to our friends at NPM for some advice.

@crequena-babbel
Copy link

@joshk any updates in this regard?

@crequena-babbel
Copy link

My workaround to this has been to prepend PATH to the rvm command:

  • PATH="/bin:$PATH" rvm use $(< .ruby-version) --install --binary --fuzzy

@MaximDevoir
Copy link

MaximDevoir commented Nov 12, 2019

Any update on this?

It took me a while to find the source of the problem of why commands (e.g. which or npm etc.) were working in my project root, but any other directory they were failing.

My workaround is to remove the entry from PATH with a cross-platform compatible line like this:

PATH=$(echo "$PATH" | sed 's/.\/node_modules\/.bin://')

@vitalied vitalied force-pushed the master branch 3 times, most recently from b550246 to e10c3aa Compare August 2, 2023 13:40
@vitalied vitalied force-pushed the master branch 7 times, most recently from 1a44841 to 4d03828 Compare August 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts travis-yml PR introduces changes in .travis.yml config keys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants