Exit on Coverity scan failure

travis-ci · Oct 28, 2021 · 76408e8 · 76408e8
1 parent 5f10098
commit 76408e8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/travis/build/addons/coverity_scan.rb b/lib/travis/build/addons/coverity_scan.rb
@@ -80,6 +80,11 @@ def build_command
               env << "COVERITY_SCAN_BUILD_COMMAND_PREPEND=\"${COVERITY_SCAN_BUILD_COMMAND_PREPEND:-#{@config[:build_command_prepend]}}\""
               env << "COVERITY_SCAN_BRANCH_PATTERN=${COVERITY_SCAN_BRANCH_PATTERN:-#{@config[:branch_pattern]}}"
               sh.cmd "curl -s #{@config[:build_script_url]} | #{env.join(' ')} bash", echo: true
+              sh.raw 'result=$?', echo: true
+              sh.if '$result -ne 0', echo: true do
+                sh.raw "echo -e \"\033[33;1mSkipping build_coverity due to script error\033[0m\""
+                sh.raw 'exit 1', echo: true
+              end
             end
           end
           sh.else echo:true do

diff --git a/spec/build/addons/coverity_scan_spec.rb b/spec/build/addons/coverity_scan_spec.rb
@@ -2,7 +2,7 @@
 
 describe Travis::Build::Addons::CoverityScan, :sexp do
   let(:script) { stub('script') }
-  let(:config) { {} }
+  let(:config) { { project: { name: 'test' } } }
   let(:data)   { payload_for(:push, :ruby, config: { addons: { coverity_scan: config } }) }
   let(:sh)     { Travis::Shell::Builder.new }
   let(:addon)  { described_class.new(script, sh, Travis::Build::Data.new(data), config) }
@@ -13,5 +13,7 @@
   #   let(:code) { ['CODECLIMATE_REPO_TOKEN=1234'] }
   # end
 
-  xit 'needs specs!'
+  it 'returns some lines' do
+    expect(subject).to be_present
+  end
 end