Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ids for GitHub API interaction regarding hooks #836

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

porras
Copy link
Contributor

@porras porras commented Oct 4, 2018

To avoid problems with renamed repos or users.

The endpoint is not documented but I found online mentions of it (even quoting GitHub about it, e.g.: piotrmurach/github#283) and in fact I think we use it in some other places.

@porras porras requested a review from joecorcoran October 4, 2018 09:47
@porras porras force-pushed the sg/use-ids-for-gh-api branch from a13cb25 to b3286c8 Compare October 4, 2018 09:57
Copy link
Contributor

@joecorcoran joecorcoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@porras porras deployed to org-staging October 4, 2018 10:53 Active
@porras porras merged commit 151014d into master Oct 4, 2018
@porras porras deleted the sg/use-ids-for-gh-api branch October 4, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants