Drop verification of existing firebase-tools installation

[sylveon]

This prevents travis-ci/travis-ci#8637 from happening.

The check uses the PATH, which in case of node.js projects includes node_modules/.bin. If the firebase-tools package has been installed locally, the check will pass because they are stored in said folder, so the tools will not get installed globally. The problem is that when the deploy is run, node_modules/.bin isn't in the PATH so it results in 'sh: 1: firebase: not found' when deploying.

[BanzaiMan]

I have a feeling that this is not the right fix. If the mismatch between RVM's PATH and Kernel#`'s PATH is a general problem (not just Firebase), it should be fixed in DPL::Provider.

[sylveon]

I mean, that'd be ideal, sure. But then either:

• We add node_modules/.bin to the PATH everywhere, issues like RVM claims it can't find curl when using node-which; Node.js builds contain ./node_modules/bin in $PATH travis-ci#5092 might become more and more common.
• We remove node_modules/.bin from the PATH everywhere, and we break a lot of CI builds.
• We put node_modules/.bin at the end of PATH instead of the beginning and make this PATH change everywhere. This will probably break a few CI builds, but not as much as solution 2.

[BanzaiMan]

The version specified in this PR is too old at this point.

[svenfuchs]

Hey @sylveon 👋

We are working on releasing a new major version dpl v2. The respective branch has been merged to master, and we are planning on releasing a developer preview, as well as a blog post soon, hopefully later this week.

I believe this PR here addresses your issue by adding node_modules/.bin to the PATH #1033. I believe this should be an adequate fix, what do you think?

Thank you!

[sylveon]

It should, but I don't think you linked the right PR, as it's completely unrelated to node.

[svenfuchs]

@sylveon lol, sorry about that. juggling too many PRs at the moment. here's the right one: #1032