Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update open-source-on-travis-ci-com.md #1883

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Conversation

Zearin
Copy link

@Zearin Zearin commented Jun 10, 2018

No description provided.

@plaindocs
Copy link
Contributor

Hi @Zearin

Thanks for these changes. I don't really mind either way about the line breaks, but your link syntax isn't working. See the preview here https://deploy-preview-1883--musing-lamport-7fb66c.netlify.com/user/open-source-on-travis-ci-com/

We're using Kramdown https://kramdown.gettalong.org/syntax.html#reference-links

@Zearin Zearin closed this Jun 17, 2018
@Zearin Zearin deleted the patch-1 branch June 17, 2018 15:25
@Zearin
Copy link
Author

Zearin commented Jun 17, 2018

Whoops. That’s what I get for renaming the branch! (I’ll reopen shortly.)

@plaindocs I’ve looked at the Kramdown reference you linked. I couldn’t see anything that indicated reference-style links would not work. Stumped, I checked the preview you linked… and the links are all working for me. Can you double-check the links in the preview?

@Zearin Zearin restored the patch-1 branch June 17, 2018 15:36
@Zearin Zearin reopened this Jun 17, 2018
@plaindocs plaindocs changed the base branch from master to sw-js-toc June 27, 2018 13:59
@plaindocs
Copy link
Contributor

Hey Zearin, yeah you're right, ref styles does work in Kramdown. Not sure what was going on first time I looked.

Merging in.

@plaindocs plaindocs merged commit 0808386 into travis-ci:sw-js-toc Oct 16, 2018
@plaindocs
Copy link
Contributor

Ooh, my mistake. I'll merge into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants