-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update haskell version example list to strings #1537
Conversation
Thanks @iriberri . Yeah, @BanzaiMan raised a similar issue recently, I've opened an issue to track the larger scale update. |
Why not quote when necessary instead of quoting all the things? |
Hi @polyzen! That's a good point and of course that approach would work too :-) What I tried with this PR was to use strings in all the versions, since I thought that anyone taking those examples and expanding them for their use case would just imitate the quoting and therefore won't stumble into this issue. This was however kind of a quick fix from a request - I definitely think that we need to document this in a more consistent way and also explain the limitation. We'll continue working on this as @plaindocs mentioned above :-) |
@polyzen In YAML, |
Branch: refs/heads/master Date: 2017-11-08T18:33:23-08:00 Author: Jon Dufresne (jdufresne) <[email protected]> Commit: collective/icalendar@a33a357 Quote all version strings in Travis CI configuration Per the feedback from @polyzen in PR #246, in YAML, numeric bare strings are interpreted as floats, not strings. Versions are strings and should not be coerced to a float. For example, 7.10 isn't the same as 7.1. For more details, see Travis issue: travis-ci/docs-travis-ci-com#1537 Files changed: M .travis.yml Repository: icalendar Branch: refs/heads/master Date: 2018-02-08T22:26:51+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: collective/icalendar@6eff2b0 Merge pull request #249 from jdufresne/quote-versions Quote all version strings in Travis CI configuration Files changed: M .travis.yml
Branch: refs/heads/master Date: 2017-11-08T18:33:23-08:00 Author: Jon Dufresne (jdufresne) <[email protected]> Commit: collective/icalendar@a33a357 Quote all version strings in Travis CI configuration Per the feedback from @polyzen in PR #246, in YAML, numeric bare strings are interpreted as floats, not strings. Versions are strings and should not be coerced to a float. For example, 7.10 isn't the same as 7.1. For more details, see Travis issue: travis-ci/docs-travis-ci-com#1537 Files changed: M .travis.yml Repository: icalendar Branch: refs/heads/master Date: 2018-02-08T22:26:51+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: collective/icalendar@6eff2b0 Merge pull request #249 from jdufresne/quote-versions Quote all version strings in Travis CI configuration Files changed: M .travis.yml
Branch: refs/heads/master Date: 2017-11-08T18:33:23-08:00 Author: Jon Dufresne (jdufresne) <[email protected]> Commit: collective/icalendar@a33a357 Quote all version strings in Travis CI configuration Per the feedback from @polyzen in PR #246, in YAML, numeric bare strings are interpreted as floats, not strings. Versions are strings and should not be coerced to a float. For example, 7.10 isn't the same as 7.1. For more details, see Travis issue: travis-ci/docs-travis-ci-com#1537 Files changed: M .travis.yml Repository: icalendar Branch: refs/heads/master Date: 2018-02-08T22:26:51+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: collective/icalendar@6eff2b0 Merge pull request #249 from jdufresne/quote-versions Quote all version strings in Travis CI configuration Files changed: M .travis.yml
In YAML,
- 7.10
would evaluate to version 7.1, and not 7.10.I'm updating the examples here to use a list of strings instead. This comes from a specific request to update this for Haskell, but I assume is something we want to check in general, as this would affect other languages too.