-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Danish/Dansk Translation #1179
Update Danish/Dansk Translation #1179
Conversation
2b903c0
to
b890e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinnj Thanks for your contribution!
Do you think you can find any other contributor can help us review these changes? As I don't understand Danish, it'll be great if there is somebody else can help confirm the improvements, thanks!
Just anyone who knows danish, or someone who's already contributed before? |
@martinnj just someone knows danish and also knows a little bit about open source contribution would be good enough, thanks |
@martinnj or maybe you can help review it yourself again and we can get it done, what do you think? |
Right, sorry, I completely got lost in work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The misspelled words should probably be looked at - most of the other issues are with combined words, which are a bit tricky especially when using foreign words. If you want it to be entirely correct, they should be looked at as well.
Overall, though, it looks good. Will review again once revised.
@PeterDaveHello - Sorry for the delay, should be all good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from here now :)
Hey @martinnj, TravisCI finished with status TravisBuddy Request Identifier: 19806f30-18dc-11e9-8383-81bede5545a8 |
@martinnj thanks! No mind of the build failed, I'll take care of it. |
btw, would you like to have a double confirmation from @Ekima as she's mentioned earlier? |
It is the same person, she was just logged in to another profile. |
@martinnj oh, okay, didn't know that, thanks. |
Thank you both! |
Fixed:
Also sorted the file because it makes things easier to read when translating later, but I realize it might make change reviews a little hard. Can be easily reverted though.