Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Danish/Dansk Translation #1179

Merged

Conversation

martinnj
Copy link
Contributor

@martinnj martinnj commented Nov 3, 2018

Fixed:

  • Misspelled/typo'ed danish words.
  • Stray english words in danish translations.
  • Remaining untranslated labels

Also sorted the file because it makes things easier to read when translating later, but I realize it might make change reviews a little hard. Can be easily reverted though.

@PeterDaveHello PeterDaveHello changed the title Translations/danish Update Danish/Dansk Translation Dec 19, 2018
Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinnj Thanks for your contribution!
Do you think you can find any other contributor can help us review these changes? As I don't understand Danish, it'll be great if there is somebody else can help confirm the improvements, thanks!

@martinnj
Copy link
Contributor Author

Just anyone who knows danish, or someone who's already contributed before?
The first one is easy, but the second one might be rough.

@PeterDaveHello
Copy link
Member

@martinnj just someone knows danish and also knows a little bit about open source contribution would be good enough, thanks

@PeterDaveHello
Copy link
Member

@martinnj or maybe you can help review it yourself again and we can get it done, what do you think?

@martinnj
Copy link
Contributor Author

martinnj commented Jan 13, 2019

Right, sorry, I completely got lost in work.
@Ekima think you can take a look for us?

Copy link

@svnohr svnohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The misspelled words should probably be looked at - most of the other issues are with combined words, which are a bit tricky especially when using foreign words. If you want it to be entirely correct, they should be looked at as well.

Overall, though, it looks good. Will review again once revised.

lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
lang/transgui.da Outdated Show resolved Hide resolved
@martinnj
Copy link
Contributor Author

@PeterDaveHello - Sorry for the delay, should be all good to go now.
I incorporated the changes suggested by @svnohr , and when there was a little discussion we hashed it privately.

Copy link

@svnohr svnohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from here now :)

@TravisBuddy
Copy link

Hey @martinnj,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 19806f30-18dc-11e9-8383-81bede5545a8

@PeterDaveHello
Copy link
Member

@martinnj thanks! No mind of the build failed, I'll take care of it.

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Jan 15, 2019

btw, would you like to have a double confirmation from @Ekima as she's mentioned earlier?
(or maybe you had the conversation directly already?)

@martinnj
Copy link
Contributor Author

martinnj commented Jan 17, 2019

It is the same person, she was just logged in to another profile.

@PeterDaveHello
Copy link
Member

@martinnj oh, okay, didn't know that, thanks.

@PeterDaveHello
Copy link
Member

Thank you both!

@PeterDaveHello PeterDaveHello merged commit 2b36a4c into transmission-remote-gui:master Jan 17, 2019
@martinnj martinnj deleted the translations/danish branch January 17, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants