Tus plugin: rename metadata field: type→filetype #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!
Why not add? I think it might be safer, in case some people are already relying on |
arturi
reviewed
May 22, 2018
src/plugins/Tus.js
Outdated
| meta.filetype = meta.type | ||
| delete meta.type | ||
| } | ||
| optsTus.metadata = meta | ||
|
|
There was a problem hiding this comment.
Feels like this complicates everything a bit. If we just add filetype (maybe check if it is not already set), it would be simpler.
Also, could you please add filename as well? See tus/tus-js-client@ebc5189 and https://github.com/tus/tusd/blob/5b376141903c1fd64480c06dde3dfe61d191e53d/unrouted_handler.go#L640-L643
vith
force-pushed
the
tus-metadata-filetype
branch
from
337d939 to
3207893
Compare
|
I was renaming the property simply because I didn't want the clutter of storing the same value in duplicate. But fair enough. The patch is now copying instead, and I added the filename property. |
|
Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #753
I'm assuming it's OK to just drop the original type field.