@uppy/core: fix sideEffects declaration
#4759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS files do contain some side effects, as some Uppy plugins rely on some CSS class being styled by core.
|
It was causing the
|
Murderlon
approved these changes
Oct 23, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 23, 2023
| Package | Version | Package | Version | | --------------- | ------- | --------------- | ------- | | @uppy/companion | 4.10.1 | uppy | 3.18.1 | | @uppy/core | 3.6.1 | | | - @uppy/companion: Bump jsonwebtoken from 8.5.1 to 9.0.0 in /packages/@uppy/companion (dependabot[bot] / #4751) - meta: Bump react-devtools-core from 4.25.0 to 4.28.4 (dependabot[bot] / #4756) - meta: Bump webpack from 5.74.0 to 5.88.2 (dependabot[bot] / #4740) - meta: Bump @babel/traverse from 7.22.5 to 7.23.2 (dependabot[bot] / #4739) - @uppy/core: fix `sideEffects` declaration (Antoine du Hamel / #4759)
Murderlon
added a commit
that referenced
this pull request
Nov 1, 2023
* main: More image editor improvements (#4676) @uppy/react: add useUppyState (#4711) Release: [email protected] (#4760) Bump jsonwebtoken from 8.5.1 to 9.0.0 in /packages/@uppy/companion (#4751) Bump react-devtools-core from 4.25.0 to 4.28.4 (#4756) Bump webpack from 5.74.0 to 5.88.2 (#4740) Bump @babel/traverse from 7.22.5 to 7.23.2 (#4739) @uppy/core: fix `sideEffects` declaration (#4759) Release: [email protected] (#4754) @uppy/aws-s3-multipart: fix `TypeError` (#4748) Bump tough-cookie from 4.1.2 to 4.1.3 (#4750) example: simplify code by using built-in `throwIfAborted` (#4749) @uppy/aws-s3-multipart: pass `signal` as separate arg for backward compat (#4746) meta: fix TS integration (#4741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS files do contain some side effects, as some Uppy plugins rely on some CSS class being styled by core.