Fix: Utilize user-defined onSuccess, onError, and onProgress callbacks in @uppy/tus

[cgoinglove]

This PR fixes the issue where user-defined onSuccess, onError, and onProgress callbacks were being ignored in the Tus plugin. While these options were accepted during initialization, they were not being called in the respective events.

This change ensures that if a user has provided any of these callbacks, they will be called in addition to the internal handlers.

Changes Made

• Utilized user-defined onSuccess, onError, and onProgress callbacks in the Tus plugin.
• Updated the code to check for and invoke user-defined callbacks if provided.

[arturi]

Seems like a good idea indeed. @Acconut, WDYT?

[Acconut]

It looks fine by me. But it's a question for you whether you want to allow users to receive these events using the tus-js-client callbacks and the Uppy events. That's two different approaches. Maybe you only want to support one approach.

[cgoinglove]

@arturi @Acconut

Thank you for taking the time to review my PR, especially since this is my first PR.

Thank you for your feedback. I understand that Uppy already has a .on('upload-success') event that serves a similar purpose. However, the idea behind this PR is to offer flexibility to the end-users who are accustomed to the tus-js-client callbacks like onSuccess, onError, and onProgress.

While it's true that both onSuccess and .on('upload-success') occur at the same point, providing both options gives users the freedom to choose based on their specific needs or familiarity with one approach over the other. Some users might find it more convenient to stick with tus-js-client callbacks if they are already using them in other parts of their application. Others might prefer the Uppy's event-based approach. In either case, I believe that the responsibility should lie with the users to pick the approach that best suits their needs. 🤣

[Murderlon]

But it's a question for you whether you want to allow users to receive these events using the tus-js-client callbacks and the Uppy events. That's two different approaches. Maybe you only want to support one approach.

Technically this was already possible in both. From the docs:

All options are passed to tus-js-client and we document the ones here that are required, added, or changed. This means you can also pass functions like onAfterResponse.

We recommended taking a look at the API reference from tus-js-client to know what is supported.

This PR just makes passing onError andonProgress not silently do nothing. So I would be okay with this change too.