@uppy/transloadit: Reset tus key in the file on error, so retried files are re-uploaded

[arturi]

Fixes #4412

[Murderlon]

Nice quick fix 👍

Some things I'm curious about:

• Is tus an object? If so, do we loose the tus metadata send via Tus-Metadata? Would only deleting the id within tus do the trick too?
• This problem does not exist in @uppy/tus?

[arturi]

Is tus an object? If so, do we loose the tus metadata send via Tus-Metadata? Would only deleting the id within tus do the trick too?

Yes, it is an object, but this is for @uppy/transloadit plugin only, so everything should be re-added when creating a new assembly on retry?

uppy/packages/@uppy/transloadit/src/index.js

Lines 141 to 155 in 57a71e1

	#attachAssemblyMetadata (file, status) {
	// Add the metadata parameters Transloadit needs.
	const meta = {
	...file.meta,
	assembly_url: status.assembly_url,
	filename: file.name,
	fieldname: 'file',
	}
	// Add Assembly-specific Tus endpoint.
	const tus = {
	...file.tus,
	endpoint: status.tus_url,
	// Include X-Request-ID headers for better debugging.
	addRequestId: true,
	}

I could only remove uploadUrl indeed for safety, just thought there's no point and it might keep some other side-effect we are not aware of. Maybe premature bug-fixing :)

This problem does not exist in @uppy/tus?

No, cause for @uppy/tus it’s desired behavior — if the file is already uploaded, don't re-upload again, right? For transloadit it failed because the upload is tied to the assembly.

[Murderlon]

Makes sense. Do we want to test this? I think it should be doable in cypress:

1. add file
2. upload file but intercept with failure
3. click retry
4. check if the :id in the URL is different than the previous one?

[aduh95]

I've started working on the tests.

[arturi]

Ok, I was about to. But we don't need to intercept, as we can get failure with that test file (rce-poc-transloadit.eps) from the api? Probably intercept is cleaner, cause api can change to support that broken metadata somehow.

[Murderlon]

Thanks for creating a test for this. Test may be easier to follow/edit if we take out the massive responses into variables or something. But it's more of a nit.