meta: harden linter rule for JSX/ESM validation #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using Babel parser to lint our files, which has the downside of auto-magically convert JSX syntax to classic JS syntax, which doesn't let us forbid JSX syntax on `.js` files, which makes the transition from CJS to ESM a bit error prone. Since we are no longer using language features that are not already supported by Espree parser, we can safely disable Babel parser for those files. We can re-enable it later once the transition is done.
aduh95
added
the
safe to test
github-actions
bot
removed
the
safe to test
aduh95
added
the
safe to test
github-actions
bot
removed
pending end-to-end tests
safe to test
Murderlon
added a commit
that referenced
this pull request
May 3, 2022
* main: Add `save` translation to Spanish locale (#3678) @uppy/google-drive: refactor to ESM (#3683) meta: harden linter rule for JSX/ESM validation (#3681) meta: harden linter rules for ESM/CJS validation (#3674) Release: [email protected] (#3671) Bump moment from 2.29.1 to 2.29.2 (#3635) @uppy/core: fix `TypeError` when file was removed (#3670) Release: [email protected] (#3667) Plural translation in cs_CZ local (#3666) Add license field to package.json in @uppy/vue (#3664) Add todo comments
github-actions bot
added a commit
that referenced
this pull request
May 14, 2022
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/audio | 0.3.1 | @uppy/provider-views | 2.1.0 | | @uppy/aws-s3 | 2.1.0 | @uppy/react | 2.2.0 | | @uppy/aws-s3-multipart | 2.3.0 | @uppy/react-native | 0.3.0 | | @uppy/companion-client | 2.1.0 | @uppy/screen-capture | 2.1.0 | | @uppy/core | 2.2.0 | @uppy/status-bar | 2.2.0 | | @uppy/dashboard | 2.2.0 | @uppy/svelte | 1.0.8 | | @uppy/drag-drop | 2.1.0 | @uppy/transloadit | 2.2.0 | | @uppy/file-input | 2.1.0 | @uppy/tus | 2.3.0 | | @uppy/google-drive | 2.1.0 | @uppy/url | 2.1.0 | | @uppy/image-editor | 1.2.0 | @uppy/webcam | 2.2.0 | | @uppy/instagram | 2.1.0 | @uppy/xhr-upload | 2.1.0 | | @uppy/locales | 2.1.0 | @uppy/zoom | 1.1.0 | | @uppy/onedrive | 2.1.0 | @uppy/robodog | 2.6.0 | | @uppy/progress-bar | 2.1.0 | uppy | 2.10.0 | - @uppy/audio: fix types (Merlijn Vos / #3689) - @uppy/aws-s3-multipart,@uppy/aws-s3,@uppy/core,@uppy/react,@uppy/transloadit,@uppy/tus,@uppy/xhr-upload: proposal: Cancel assemblies optional (Mikael Finstad / #3575) - @uppy/aws-s3-multipart: export interface AwsS3MultipartOptions (Matteo Padovano / #3709) - @uppy/companion-client: refactor to ESM (Antoine du Hamel / #3693) - @uppy/companion: Only deploy on companion changes (kiloreux / #3677) - @uppy/core: add definition for addFiles method (Matteo Padovano / #3556) - @uppy/core: wrap plugins in div.uppy-Root and set dir attrubute in UIPlugin (Artur Paikin / #3692) - @uppy/google-drive: refactor to ESM (Antoine du Hamel / #3683) - @uppy/image-editor: refactor to ESM (Antoine du Hamel / #3685) - @uppy/instagram: refactor to ESM (Antoine du Hamel / #3696) - @uppy/locales: Add `save` translation to Spanish locale (Juan Carlos Alonso / #3678) - @uppy/locales: refactor to ESM (Antoine du Hamel / #3707) - @uppy/onedrive: refactor to ESM (Antoine du Hamel / #3694) - @uppy/progress-bar: refactor to ESM (Antoine du Hamel / #3706) - @uppy/provider-views: refactor to ESM (Antoine du Hamel / #3715) - @uppy/react: Support React 18 in @uppy/react (Merlijn Vos / #3680) - @uppy/screen-capture: refactor to ESM (Antoine du Hamel / #3698) - @uppy/status-bar: refactor to ESM (Antoine du Hamel / #3697) - @uppy/transloadit: add rate limiting for assembly creation and status polling (Antoine du Hamel / #3718) - @uppy/tus: refactor to ESM (Antoine du Hamel / #3724) - @uppy/url: refactor to ESM (Antoine du Hamel / #3713) - @uppy/webcam: refactor to ESM (Antoine du Hamel / #3686) - @uppy/xhr-upload: refactor to ESM (Antoine du Hamel / #3695) - @uppy/zoom: refactor to ESM (Antoine du Hamel / #3699) - meta: e2e: fix failing test (Antoine du Hamel / #3722) - test: harden linter rule for JSX/ESM validation (Antoine du Hamel / #3681) - test: harden linter rules for ESM/CJS validation (Antoine du Hamel / #3674) - test: Increase retries to trigger longer retryDelay in tus (Artur Paikin / #3726) - test: Remove `it.only` from e2e test (Merlijn Vos / #3690) - tests: Make Cypress more stable & add e2e test for error events when upload fails (Merlijn Vos / #3662)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using Babel parser to lint our files, which has the
downside of auto-magically convert JSX syntax to classic JS syntax,
which doesn't let us forbid JSX syntax on
.jsfiles, which makesthe transition from CJS to ESM a bit error prone.
Since we are no longer using language features that are not already
supported by Espree parser, we can safely disable Babel parser for
those files. We can re-enable it later once the transition is done.