Fix getFileType for dicom images
#3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mifi
reviewed
Apr 11, 2022
mifi
approved these changes
Apr 11, 2022
I think you are mixing up two things: our mapping of file types for internals, and the optional restrictions you can apply. But we are I suppose implicitly restricting types that we do not map. |
|
Indeed this is for file type detection only, when the browser / OS don't set one, we fallback to file extension to set the correct type. I've chosen custom list vs a full package specifically for reasons Merlijn mentioned — ie 200kb. |
arturi
approved these changes
Apr 14, 2022
|
Ok, I thought the upload would not work if the mime type is missing, thereby restricting uploads that uppy can handle to only a handful of mime types. If that's not the case, then yea it makes sense to just add custom detection for common files to save space |
github-actions bot
added a commit
that referenced
this pull request
Apr 27, 2022
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3-multipart | 2.2.2 | @uppy/file-input | 2.0.6 | | @uppy/box | 1.0.6 | @uppy/form | 2.0.5 | | @uppy/companion | 3.5.1 | @uppy/locales | 2.0.9 | | @uppy/compressor | 0.2.5 | @uppy/transloadit | 2.1.5 | | @uppy/core | 2.1.9 | @uppy/utils | 4.0.7 | | @uppy/drag-drop | 2.0.7 | @uppy/vue | 0.4.7 | | @uppy/drop-target | 1.1.3 | @uppy/robodog | 2.5.4 | | @uppy/dropbox | 2.0.6 | uppy | 2.9.4 | | @uppy/facebook | 2.0.6 | | | - @uppy/locales: Plural translation in cs_CZ local (JakubHaladej / #3666) - @uppy/vue: Add license field to package.json in @uppy/vue (Tobias Trumm / #3664) - meta: Add todo comments (Murderlon) - @uppy/facebook: refactor to ESM (Antoine du Hamel / #3653) - meta: locale-pack: refactor to use more parallel processing (Antoine du Hamel / #3630) - @uppy/file-input: refactor to ESM (Antoine du Hamel / #3652) - meta: sign requests sent to Transloadit in e2e suite (Antoine du Hamel / #3656) - meta: add `VITE_TRANSLOADIT_SECRET` for e2e (Antoine du Hamel) - meta: Update BACKLOG.md (Artur Paikin) - @uppy/form: refactor to ESM (Antoine du Hamel / #3654) - @uppy/dropbox: refactor to ESM (Antoine du Hamel / #3651) - meta: sign requests sent to Transloadit in dev env (Antoine du Hamel / #3517) - @uppy/drop-target: refactor to ESM (Antoine du Hamel / #3648) - @uppy/core: fix `TypeError` when file was removed (Antoine du Hamel / #3650) - @uppy/drag-drop: refactor to ESM (Antoine du Hamel / #3647) - meta: update outdated files (Antoine du Hamel / #3646) - @uppy/compressor: Set meta on file compression (Camilo Forero / #3644) - @uppy/transloadit: improve fetch error handling (Antoine du Hamel / #3637) - @uppy/box: refactor to ESM (Antoine du Hamel / #3643) - @uppy/utils: Fix getFileType for dicom images (Merlijn Vos / #3610) - @uppy/aws-s3-multipart: Add `companionCookiesRule` type to @uppy/aws-s3-multipart (Mauricio Ribeiro / #3623)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3-multipart | 2.2.2 | @uppy/file-input | 2.0.6 | | @uppy/box | 1.0.6 | @uppy/form | 2.0.5 | | @uppy/companion | 3.5.1 | @uppy/locales | 2.0.9 | | @uppy/compressor | 0.2.5 | @uppy/transloadit | 2.1.5 | | @uppy/core | 2.1.9 | @uppy/utils | 4.0.7 | | @uppy/drag-drop | 2.0.7 | @uppy/vue | 0.4.7 | | @uppy/drop-target | 1.1.3 | @uppy/robodog | 2.5.4 | | @uppy/dropbox | 2.0.6 | uppy | 2.9.4 | | @uppy/facebook | 2.0.6 | | | - @uppy/locales: Plural translation in cs_CZ local (JakubHaladej / transloadit#3666) - @uppy/vue: Add license field to package.json in @uppy/vue (Tobias Trumm / transloadit#3664) - meta: Add todo comments (Murderlon) - @uppy/facebook: refactor to ESM (Antoine du Hamel / transloadit#3653) - meta: locale-pack: refactor to use more parallel processing (Antoine du Hamel / transloadit#3630) - @uppy/file-input: refactor to ESM (Antoine du Hamel / transloadit#3652) - meta: sign requests sent to Transloadit in e2e suite (Antoine du Hamel / transloadit#3656) - meta: add `VITE_TRANSLOADIT_SECRET` for e2e (Antoine du Hamel) - meta: Update BACKLOG.md (Artur Paikin) - @uppy/form: refactor to ESM (Antoine du Hamel / transloadit#3654) - @uppy/dropbox: refactor to ESM (Antoine du Hamel / transloadit#3651) - meta: sign requests sent to Transloadit in dev env (Antoine du Hamel / transloadit#3517) - @uppy/drop-target: refactor to ESM (Antoine du Hamel / transloadit#3648) - @uppy/core: fix `TypeError` when file was removed (Antoine du Hamel / transloadit#3650) - @uppy/drag-drop: refactor to ESM (Antoine du Hamel / transloadit#3647) - meta: update outdated files (Antoine du Hamel / transloadit#3646) - @uppy/compressor: Set meta on file compression (Camilo Forero / transloadit#3644) - @uppy/transloadit: improve fetch error handling (Antoine du Hamel / transloadit#3637) - @uppy/box: refactor to ESM (Antoine du Hamel / transloadit#3643) - @uppy/utils: Fix getFileType for dicom images (Merlijn Vos / transloadit#3610) - @uppy/aws-s3-multipart: Add `companionCookiesRule` type to @uppy/aws-s3-multipart (Mauricio Ribeiro / transloadit#3623)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3439
Begs the question again whether we should just use a library for mime types because I'm sure this is not the last time this is happening. Unfortunately adding one would be around 20KB, I'm not sure how much our file is but probably way less. It's a tradeoff.