Add chunks back to prepareUploadParts, indexed by partNumber #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murderlon
approved these changes
Mar 2, 2022
This was referenced Mar 2, 2022
github-actions bot
added a commit
that referenced
this pull request
Mar 2, 2022
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/angular | 0.3.0 | @uppy/locales | 2.0.7 | | @uppy/aws-s3-multipart | 2.2.1 | uppy | 2.7.0 | | @uppy/companion | 3.3.1 | | | - @uppy/companion: fix unstable test (Mikael Finstad) - @uppy/companion: replace debug (Mikael Finstad) - @uppy/companion: Fix COMPANION_PATH (Mikael Finstad / #3515) - @uppy/angular: update ng version (Antoine du Hamel / #3503) - @uppy/companion: Upload protocol "s3-multipart" does not use the chunkSize option (Gabi Ganam / #3511) - @uppy/aws-s3-multipart: Add chunks back to prepareUploadParts, indexed by partNumber (Kevin West / #3520) - website: Add “Stop the war” banner (Artur Paikin / #3518) - @uppy/locales: Update zh_CN.js (linxunzyf / #3513) - meta: update remark dependencies (Antoine du Hamel / #3502)
|
Nice! |
Murderlon
added a commit
that referenced
this pull request
Mar 7, 2022
* main: provider-view: fix breadcrumbs (#3535) Update BACKLOG.md Update ru_RU.js (#3529) @uppy/companion: reorder reqToOptions (#3530) meta: Fix yarn caching in github actions (#3526) Release: [email protected] (#3525) fix unstable test replace debug Fix COMPANION_PATH (#3515) @uppy/angular: update ng version (#3503) Upload protocol "s3-multipart" does not use the chunkSize option (#3511) Add chunks back to prepareUploadParts, indexed by partNumber (#3520) website: Add “Stop the war” banner (#3518)
vymao
pushed a commit
to vymao/uppy
that referenced
this pull request
Mar 29, 2022
* main: provider-view: fix breadcrumbs (transloadit#3535) Update BACKLOG.md Update ru_RU.js (transloadit#3529) @uppy/companion: reorder reqToOptions (transloadit#3530) meta: Fix yarn caching in github actions (transloadit#3526) Release: [email protected] (transloadit#3525) fix unstable test replace debug Fix COMPANION_PATH (transloadit#3515) @uppy/angular: update ng version (transloadit#3503) Upload protocol "s3-multipart" does not use the chunkSize option (transloadit#3511) Add chunks back to prepareUploadParts, indexed by partNumber (transloadit#3520) website: Add “Stop the war” banner (transloadit#3518)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/angular | 0.3.0 | @uppy/locales | 2.0.7 | | @uppy/aws-s3-multipart | 2.2.1 | uppy | 2.7.0 | | @uppy/companion | 3.3.1 | | | - @uppy/companion: fix unstable test (Mikael Finstad) - @uppy/companion: replace debug (Mikael Finstad) - @uppy/companion: Fix COMPANION_PATH (Mikael Finstad / transloadit#3515) - @uppy/angular: update ng version (Antoine du Hamel / transloadit#3503) - @uppy/companion: Upload protocol "s3-multipart" does not use the chunkSize option (Gabi Ganam / transloadit#3511) - @uppy/aws-s3-multipart: Add chunks back to prepareUploadParts, indexed by partNumber (Kevin West / transloadit#3520) - website: Add “Stop the war” banner (Artur Paikin / transloadit#3518) - @uppy/locales: Update zh_CN.js (linxunzyf / transloadit#3513) - meta: update remark dependencies (Antoine du Hamel / transloadit#3502)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the part data passed to prepareUploadParts to also include an object of chunk data. Every part number passed should have a key in the object, with the value being it's associated chunk.
I added some tests for validation, but it mostly just tests that the chunks are indexed correctly in the object. It would be nice to actually validate that it's passing the proper chunk data as well, but I couldn't figure out how to do something like that with the mocked Blob objects.
This is intended to fix #3391