Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'done' to nb_NO.js #3200

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Add 'done' to nb_NO.js #3200

merged 2 commits into from
Sep 16, 2021

Conversation

Adrrei
Copy link
Contributor

@Adrrei Adrrei commented Sep 16, 2021

"Done" is missing for the Norwegian locale.

For "proof" that this is a correct translation, please see: Google Translate.

Thanks!

"Done" is missing for the Norwegian locale.

For "proof" that this is a correct translation, please see: [Google Translate](https://translate.google.com/?sl=en&tl=no&text=Done&op=translate).

Thanks!
@Adrrei Adrrei changed the title Update nb_NO.js Add 'done' to nb_NO.js Sep 16, 2021
@Adrrei
Copy link
Contributor Author

Adrrei commented Sep 16, 2021

On second thoughts, having "Ferdig" twice at the bottom would be confusing UX.
image

In addition, the header says "Upload complete", also using the word "ferdig".
image

Changing complete: 'Ferdig', to complete: 'Fullført', would be more descriptive.

This would result in:
image

@aduh95 aduh95 requested a review from mifi September 16, 2021 13:25
Copy link
Contributor

@mifi mifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut dette.

@Murderlon Murderlon merged commit ecd2dec into transloadit:main Sep 16, 2021
Murderlon added a commit that referenced this pull request Sep 20, 2021
* main:
  Show all details on mobile when `showProgressDetails` is `true` (#3174)
  @uppt/xhr-upload: fix `this.uppy is undefined` error (#3207)
  ci: test on Node.js v16.x (#3205)
  @uppy/dashboard: fix linter (#3206)
  Add `2.1.1` to `CHANGELOG.md`
  Release
  Release
  Fix "attempted to use private field on non-instance" in `SearchProvider` (#3201)
  Add 'done' to `nb_NO.js` (#3200)
  @uppy/transloadit: fix unhandledPromiseRejection failures (#3197)
  fix: AbortController is not defined on Node.js (Server Side Render) (#3169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants