-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all details on mobile when showProgressDetails
is true
#3174
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4b7a2cc
Allow hoisted functions in `.eslintrc`
Murderlon c3eafa5
Abstract UI components into `Components.js`
Murderlon d1efec3
Resolve all eslint warnings in `Components.js`
Murderlon 299a784
Abstract `calculateProcessingProgress` and resolve all eslint warning…
Murderlon c65a15f
Render progress bar with a switch statement
Murderlon 866c0e3
Create `getProgressValue`, `getIsIndeterminate`, `getIsHidden`
Murderlon 6786708
Resolve eslint warnings in `index.js`
Murderlon 4ef070f
Show all details on mobile when `showProgressDetails` is `true`
Murderlon 5569446
Remove item from `BACKLOG.md`
Murderlon e1f74b8
Merge branch 'main' into statusbar-mobile
Murderlon de823a6
Apply suggestions from code review
Murderlon e3e5620
Revert "Apply suggestions from code review"
Murderlon 340748d
Manually apply code suggestions
Murderlon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you check the box instead of removing the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have a huge backlog I figured removing might be best to unclutter things.