Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion:dropbox: exclude non downloadable files in fetched list #2493

Conversation

johnnyperkins
Copy link
Contributor

Currently when DropBox fetches a list of files it includes files with is_downloadable: false.
This causes companion to return a 409 conflict when trying to upload these files from DropBox.
This simple fix tells DropBox not to include these files in the fetched list.

This seems like the best fix to me although there are two alternatives:

  1. Add an indicator when displaying the file so users know they can't upload the file.
    This way users aren't confused to why they can't see the file.
  2. Use DropBox's api to export the file to a downloadable format and upload that. See

If either of those two options are desirable it still seems best to merge this change as a better intermediate solution.
Showing a user request to dropbox returned 409 is not desirable or actionable.

@transloadit transloadit deleted a comment from edsson78 Sep 1, 2020
@transloadit transloadit deleted a comment from edsson78 Sep 1, 2020
@ifedapoolarewaju ifedapoolarewaju merged commit 3942046 into transloadit:master Sep 1, 2020
@ifedapoolarewaju
Copy link
Contributor

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants