companion:dropbox: exclude non downloadable files in fetched list #2493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when DropBox fetches a list of files it includes files with
is_downloadable: false
.This causes companion to return a
409 conflict
when trying to upload these files from DropBox.This simple fix tells DropBox not to include these files in the fetched list.
This seems like the best fix to me although there are two alternatives:
This way users aren't confused to why they can't see the file.
If either of those two options are desirable it still seems best to merge this change as a better intermediate solution.
Showing a user
request to dropbox returned 409
is not desirable or actionable.