companion: fix multipart upload #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
approved these changes
Aug 31, 2020
I've just tested this and it's indeed working! Thanks for the effort! |
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following from this PR, I dug deeper and found that
content-lengthis actually set by the request module for the case of form data. It is only not set for the case of read streams.So this PR removes the FormData hack, and only sets content-length for the case of non-formdata uploads.
This PR is also important because the FormData hack actually doesn't work. It leveraged on an outdated internal behaviour of the
requestmodule which is no longer the same.cc @johnnyperkins @mejiaej