Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to upload whole folders to dashboard #2334

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

bdirito
Copy link
Contributor

@bdirito bdirito commented Jun 22, 2020

Adds a new configuration option to dashboard browserUploadType

This can be set to files (default) folders or both. Relies on the webkitdirectory attribute on input elements. webkitdirectory is not officially standardized but support is widespread https://caniuse.com/#feat=input-file-directory.

This feature was slated for the 1.18 release.

@bdirito
Copy link
Contributor Author

bdirito commented Jun 23, 2020

rebased off transloadit/uppy@master to fix merge conflict

Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks great. Just a few comments ⬇️

packages/@uppy/dashboard/src/index.js Outdated Show resolved Hide resolved
packages/@uppy/dashboard/src/index.js Outdated Show resolved Hide resolved
packages/@uppy/dashboard/src/components/AddFiles.js Outdated Show resolved Hide resolved
packages/@uppy/dashboard/src/components/AddFiles.js Outdated Show resolved Hide resolved
@bdirito
Copy link
Contributor Author

bdirito commented Jun 24, 2020

@goto-bus-stop - updated for pr comments

@bdirito
Copy link
Contributor Author

bdirito commented Jun 29, 2020

Made the relevant changes last week; however as im not sure of your preferred processes i also explicitly resolved the comments in github [just now].

@bdirito bdirito requested a review from goto-bus-stop June 29, 2020 20:28
@goto-bus-stop
Copy link
Contributor

Sorry for not keeping you in the loop—I think this looks great code-wise, thanks!

I was still talking with @arturi about the option name…I think browserUploadType is maybe a little cryptic. We were thinking of something like selectionType, or something like fileBrowseType. The idea behind those suggestions is that the option affects what you can select / what you can browse for, but not really how they are being uploaded. How do you feel about those? Or perhaps there is yet another name we could pick?

@bdirito
Copy link
Contributor Author

bdirito commented Jul 1, 2020

fair point. I think perhaps fileManagerSelectionType? That has the issue of including file in the option name when files is one of the possible values. On the otherhand the created interface on selecting the dashboard button for either of these things still a 'file manager'. Though I dont know if I care too much as to what the option name is. Just let me know what to go with and I'll get things updated for the new value.

@bdirito
Copy link
Contributor Author

bdirito commented Jul 7, 2020

@goto-bus-stop @arturi

I ended up just going with browserUploadType -> fileManagerSelectionType just to get this moving. If you want something else let me know.

@arturi arturi self-requested a review July 13, 2020 14:45
@goto-bus-stop goto-bus-stop merged commit 4ad07f5 into transloadit:master Jul 21, 2020
@goto-bus-stop
Copy link
Contributor

@bdirito I think we're happy with that 😄 thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants