-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the ability to upload whole folders to dashboard #2334
Conversation
rebased off transloadit/uppy@master to fix merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This looks great. Just a few comments ⬇️
@goto-bus-stop - updated for pr comments |
Made the relevant changes last week; however as im not sure of your preferred processes i also explicitly resolved the comments in github [just now]. |
Sorry for not keeping you in the loop—I think this looks great code-wise, thanks! I was still talking with @arturi about the option name…I think |
fair point. I think perhaps |
I ended up just going with |
@bdirito I think we're happy with that 😄 thanks again for the PR! |
Adds a new configuration option to dashboard
browserUploadType
This can be set to
files
(default)folders
orboth
. Relies on thewebkitdirectory
attribute on input elements.webkitdirectory
is not officially standardized but support is widespread https://caniuse.com/#feat=input-file-directory.This feature was slated for the 1.18 release.