Upgrade standard to v14 #1860
Merged
Upgrade standard to v14 #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvz
reviewed
Oct 4, 2019
arturi
approved these changes
Oct 9, 2019
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
* Update eslint dependencies. * standard --fix * build: disable handler name lint rule * status-bar: manually fix lint errors * webcam: manually fix lint errors * url: manually fix lint errors * react-native: manually fix lint errors * dashboard: manually fix lint errors * informer: manually fix linting errors * progress-bar: manually fix lint errors * provider-views: manually fix lint errors * redux-dev-tools: manually fix lint errors * build: disable buggy no-unused-vars rule * examples: manually fix lint errors * ` quotes for code things, ' for text things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has some pretty invasive changes, especially for JSX alignment rules.
Previously, this was fine:
but now standard wants the open and close tag to be at the same indent level, so it has to be
That changes the indent level of the
something, too, so it's where the majority of the diff in this PR comes from.This disables the new
react/jsx-handler-namesrule because I didn't want to rename a bunch of functions or add dummy functions. It's kept as a warning so we can follow it for new code.This disables the
no-unused-varsrule because it has an issue with loops likefor (const entry in iterator), whereentryis flagged even if it is used. I've added an asana task for me for next week to check if that bug still exists.