Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ar_SA.js #1673

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Create ar_SA.js #1673

merged 1 commit into from
Jun 18, 2019

Conversation

HussainAlkhalifah
Copy link
Contributor

I needed Uppy to be in Arabic so i thought I contribute it because I already made it, Awesome job btw

kvz
kvz approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@kvz kvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so kindly for sharing!

@kvz
Copy link
Member

kvz commented Jun 18, 2019

Looking at the CI I’m seeing these failures:

/home/travis/build/transloadit/uppy/packages/@uppy/locales/src/ar_SA.js
1:7 error Identifier 'ar_SA' is not in camel case camelcase
143:31 error Identifier 'ar_SA' is not in camel case camelcase
146:18 error Identifier 'ar_SA' is not in camel case camelcase

Will sort those out later myself and merge, thanks again!

@HussainAlkhalifah
Copy link
Contributor Author

HussainAlkhalifah commented Jun 18, 2019 via email

kvz added a commit that referenced this pull request Jun 18, 2019
@kvz
Move camelcase linting exception to linting config
fe0e914 
Ref: #1673

Q: Should we just name those vars `locale` or `obj` or whatever? No need to have the locale name in it i think?

So no `const fr_FR = {}` but `const locale = {}` ?

/cc @arturi
@kvz kvz merged commit a808b1d into transloadit:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvz kvz kvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HussainAlkhalifah @kvz