Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/dashboard - made paste work while we're focused on buttons #1619

Merged
merged 1 commit into from
May 31, 2019

Conversation

lakesare
Copy link
Contributor

@lakesare lakesare commented May 31, 2019

It's a manually cherry-picked PR #1583, because that one was based on the accessibility branch (that diverged with this PR anyway).

Chrome: works
Firefox: works
Safari: works
Edge: works
IE11: doesn't work, I believe IE11 doesn't yet support file pastes (https://caniuse.com/#search=paste).

Closes #1577

@lakesare lakesare requested a review from arturi May 31, 2019 06:48
@arturi arturi merged commit 2db91e6 into master May 31, 2019
@arturi arturi deleted the fix/make-paste-work-when-buttons-are-focused branch May 31, 2019 15:30
@arturi
Copy link
Contributor

arturi commented May 31, 2019

Works, thank you!

Discovered another issue with pasting while testing this. Paste 3 images at once, instead of 1:

  • Chrome will paste only the last one.
  • Safari will paste all (preserving their correct names!).
  • Firefox will trigger the Url plugin (cause it thinks it’s text/url?).

🤯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste works with certain quirks in Chrome
2 participants