Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

companion-client: remove the use of window.location #1393

Merged
merged 1 commit into from
Apr 2, 2019
Merged

companion-client: remove the use of window.location #1393

merged 1 commit into from
Apr 2, 2019

Conversation

ifedapoolarewaju
Copy link
Contributor

No description provided.

@ifedapoolarewaju ifedapoolarewaju requested review from arturi and kvz March 29, 2019 18:14
arturi
arturi approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@arturi arturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should specify in docs, that if http:// is omitted, we’ll default to wss?

@ifedapoolarewaju ifedapoolarewaju force-pushed the remove-window-location branch from 7ac0929 to 62305be Compare April 1, 2019 13:44
@arturi arturi merged commit d3a6be7 into master Apr 2, 2019
@arturi arturi deleted the remove-window-location branch April 2, 2019 08:57
@snyk-bot snyk-bot mentioned this pull request Dec 22, 2020
Open
@trabab trabab mentioned this pull request Oct 20, 2022
Open
@trabab trabab mentioned this pull request Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvz kvz kvz left review comments

@arturi arturi arturi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ifedapoolarewaju @kvz @arturi