Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Headers type inside of the XHRUploadOptions #4547

Closed
2 tasks done
masum-ulu opened this issue Jul 5, 2023 · 1 comment · Fixed by #4549
Closed
2 tasks done

Export Headers type inside of the XHRUploadOptions #4547

masum-ulu opened this issue Jul 5, 2023 · 1 comment · Fixed by #4549
Labels

Comments

@masum-ulu
Copy link
Contributor

masum-ulu commented Jul 5, 2023

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

It might be good export Headers type. When we use XHRUpload class it also takes headers property but this property's type is not exported if you export that type we can use directly from library, otherwise we need to create our custom type. it looks unnecessary

Excepted

export type Headers = {
  [name: string]: string | number
}

Original Line
type Headers = {
[name: string]: string | number
}

Error Message

image

Solution

it's enough to add export keyword

Alternatives

Create custom type with the same name

@Murderlon
Copy link
Member

PRs welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants