Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the corsOrigins #3548

Closed
wanghq opened this issue Mar 8, 2022 · 2 comments · Fixed by #3554
Closed

Document the corsOrigins #3548

wanghq opened this issue Mar 8, 2022 · 2 comments · Fixed by #3554
Labels
Feature

Comments

@wanghq
Copy link

wanghq commented Mar 8, 2022

I don't see the corsOrigins key is documented here (https://uppy.io/docs/companion/#Options). Seems it's used to set the cors origin. Otherwise the companion endpoints allow any origin to access.
@Murderlon
Copy link
Member

Seems to come from the documented env var:

uppy/packages/@uppy/companion/src/standalone/index.js

Line 25 in 994acff

corsOrigins = process.env.COMPANION_CLIENT_ORIGINS

If it also can be passed as a regular option, then indeed it should also be documented there.

cc @mifi

mifi added a commit that referenced this issue Mar 10, 2022
@mifi
add corsOrigins to docs
1d9ad62 
fixes #3548
@mifi mifi mentioned this issue Mar 10, 2022
Merged
@mifi
Copy link
Contributor

mifi commented Mar 10, 2022

created a pr for the docs

mifi added a commit that referenced this issue Mar 10, 2022
@mifi
add corsOrigins to docs (#3554)
ae1c512 
fixes #3548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add corsOrigins to docs transloadit/uppy
3 participants
@wanghq @mifi @Murderlon