-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Companion standalone seems to ignore COMPANION_PATH #3514
Labels
Comments
mifi
added a commit
that referenced
this issue
Feb 25, 2022
make sure it serves everything served behind that path fixes #3514
Merged
Hi. It seems like not all paths are served (including those two that you were testing root I've created a PR for this |
I can confirm that requests to |
mifi
added a commit
that referenced
this issue
Mar 2, 2022
* Fix COMPANION_PATH make sure it serves everything served behind that path fixes #3514 * add tests for subpath * chmod +x companion.sh * remove process.exit as it's considered harmful in this case an error thrown will also be printed to stderr * add backward compatible redirect * Apply suggestions from code review Co-authored-by: Antoine du Hamel <[email protected]> * fix oops Co-authored-by: Antoine du Hamel <[email protected]>
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this issue
Jun 27, 2023
* Fix COMPANION_PATH make sure it serves everything served behind that path fixes transloadit#3514 * add tests for subpath * chmod +x companion.sh * remove process.exit as it's considered harmful in this case an error thrown will also be printed to stderr * add backward compatible redirect * Apply suggestions from code review Co-authored-by: Antoine du Hamel <[email protected]> * fix oops Co-authored-by: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running the companion standalone server both as the Node application and the latest Docker image, I can't get it to respect the
COMPANION_PATH
environment variable.When I set the value to something like
/path/to/companion
, requests tolocalhost:3020/path/to/companion/
fail with a 404, and only requests to the rootlocalhost:3020/
andlocalhost:3020/metrics
return 200s.Node app:
Docker image:
Am I misunderstanding the purpose of this configuration variable? I would expect in both cases that requests to
localhost:3020/path/to/companion/
would return the homepage banner.The text was updated successfully, but these errors were encountered: