S3 mutipart with limit only uploads to the limit and then hangs

[mskelton]

When using the limit option and the S3 multipart plugin, any files after the limit hang indefinitely and don't get uploaded. For example, if I was to set a limit of 5 and upload 7 files, the first 5 would upload fine but the last two would just hang indefinitely.

The regular S3 plugin does not have this problem and works just fine.

To reproduce the problem, simply open https://github.com/transloadit/uppy/blob/master/examples/aws-companion/main.js and update the file like so. Then run it and upload more than 5 files to see how the files after 5 hang.

const Uppy = require('@uppy/core')
const GoogleDrive = require('@uppy/google-drive')
const Webcam = require('@uppy/webcam')
const Dashboard = require('@uppy/dashboard')
const AwsS3Multipart = require('@uppy/aws-s3-mulipart')
const uppy = Uppy({
  debug: true,
  autoProceed: false
})
uppy.use(GoogleDrive, {
  companionUrl: 'http://localhost:3020'
})
uppy.use(Webcam)
uppy.use(Dashboard, {
  inline: true,
  target: 'body',
  plugins: ['GoogleDrive', 'Webcam']
})
uppy.use(AwsS3Multipart, {
  companionUrl: 'http://localhost:3020',
  limit: 5
})

[arturi]

Hi! We’ve recently released a new version of @uppy/[email protected], where limit bugs were hopefully fixed. Are you on the latest version? If not, could you try upgrading?

[mskelton]

Yes, I am on version 1.3.1. The example that I showed in the description was from the Uppy source which was freshly cloned yesterday afternoon when I was writing up the issue.

[steverob]

Can confirm the same. Happened to me after upgrading to 1.3.1 from 1.3.0 (limit did not even work here).

[goto-bus-stop]

gah, this was supposed to be fixed by #1855. looking...

[goto-bus-stop]

Silly mistake, thanks for the report. Gonna get #1887 out in a patch release today.

[mskelton]

Fixed in 1.3.3