Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of resolve-url is making @uppy/aws-s3 not working in React Native (Expo) #1720

Closed
HommeSauvage opened this issue Jul 10, 2019 · 1 comment · Fixed by #1854
Closed

Use of resolve-url is making @uppy/aws-s3 not working in React Native (Expo) #1720

HommeSauvage opened this issue Jul 10, 2019 · 1 comment · Fixed by #1854
Assignees
@goto-bus-stop
Labels
AWS S3 Plugin that handles uploads to Amazon AWS S3 Bug

Comments

@HommeSauvage
Copy link

The package resolve-url required in @uppy/aws-s3 uses document to resolve the url which makes @uppy/aws-s3 unusable in React Native.
@goto-bus-stop goto-bus-stop added AWS S3 Plugin that handles uploads to Amazon AWS S3 and removed Triage labels Jul 10, 2019
@goto-bus-stop goto-bus-stop self-assigned this Jul 10, 2019
@goto-bus-stop
Copy link
Contributor

I think we can use https://www.npmjs.com/package/url-parse instead, it's also used by tus-js-client inside the @uppy/tus plugin.

goto-bus-stop added a commit that referenced this issue Sep 30, 2019
@goto-bus-stop
aws-s3: replace resolve-url by url-parse
d6e11ce 
So it works in browser-ish, but non-DOM, environments. Will use the
global `URL` API if available, and fall back to url-parse, which has a
compatible-enough API.

Fixes #1720
@goto-bus-stop goto-bus-stop mentioned this issue Sep 30, 2019
Merged
goto-bus-stop added a commit that referenced this issue Oct 4, 2019
@goto-bus-stop
aws-s3: replace resolve-url by url-parse (#1854)
0f81d70 
So it works in browser-ish, but non-DOM, environments. Will use the
global `URL` API if available, and fall back to url-parse, which has a
compatible-enough API.

Fixes #1720
This was referenced Jul 27, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
AWS S3 Plugin that handles uploads to Amazon AWS S3 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aws-s3: replace resolve-url by url-parse transloadit/uppy
2 participants
@goto-bus-stop @HommeSauvage