Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsS3Multipart plugin cancels upload with uploadId===null #1146

Closed
mattes3 opened this issue Nov 10, 2018 · 1 comment · Fixed by #1855
Closed

AwsS3Multipart plugin cancels upload with uploadId===null #1146

mattes3 opened this issue Nov 10, 2018 · 1 comment · Fixed by #1855
Assignees
Labels
AWS S3 Plugin that handles uploads to Amazon AWS S3 Bug

Comments

@mattes3
Copy link

mattes3 commented Nov 10, 2018

I have started an upload of five big files (about 260 MB each). I have passed an options object to the plug-in like this:

this.uppy.use(AwsS3Multipart, {
  createMultipartUpload: (file) => {...},
  abortMultipartUpload: (file, { uploadId, key }) => {...},
  ...
});

Uppy started the first 2 of the 5 uploads (createMultipartUpload was called twice).

Suddenly, I clicked the cancel button ("X") on one of the other 3 uploads that had not started, yet. abortMultipartUpload was called with uploadId === null. My code did not expect that and crashed.

Is this the expected behavior or is this a bug?

@mattes3 mattes3 changed the title AwsS3Multipart plugin cancels upload with uploadId === null AwsS3Multipart plugin cancels upload with uploadId===null Nov 10, 2018
@goto-bus-stop goto-bus-stop added Bug AWS S3 Plugin that handles uploads to Amazon AWS S3 labels Nov 12, 2018
@goto-bus-stop
Copy link
Contributor

Yes, that sounds like a bug, we don't need to call abortMultipartUpload on uploads that haven't started yet!

goto-bus-stop added a commit that referenced this issue Oct 9, 2019
* aws-s3-multipart: prevent deadlock in rate limit queue

* utils: fix RateLimitedQueue thrashing when aborting all items

* aws-s3-multipart: only send abort request if upload was already created, fixes #1146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWS S3 Plugin that handles uploads to Amazon AWS S3 Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants