Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move over migration guide #95

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Move over migration guide #95

merged 5 commits into from
Mar 30, 2023

Conversation

YukeshShr
Copy link
Contributor

@YukeshShr YukeshShr commented Mar 30, 2023 •
edited by Murderlon
Loading

Closes #92

@lekevbot lekevbot added the uppy The open source file uploader label Mar 30, 2023
@YukeshShr YukeshShr requested a review from Murderlon March 30, 2023 12:53
Murderlon
Murderlon reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Did you checkout how this looks locally?

docs/guides/migration-guides.md Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
@Murderlon
Copy link
Member

There are also linter issues. You can run corepack yarn lint locally and perhaps corepack yarn format.

@YukeshShr
Copy link
Contributor Author

Thanks a lot! Did you checkout how this looks locally?

Looks fine locally.

@YukeshShr YukeshShr requested a review from Murderlon March 30, 2023 13:38
@Murderlon Murderlon enabled auto-merge March 30, 2023 13:51
@Murderlon Murderlon added this pull request to the merge queue Mar 30, 2023
@Murderlon
Copy link
Member

Thanks a lot!

Merged via the queue into main with commit 563c4e8 Mar 30, 2023
@Murderlon Murderlon deleted the update-migration-guide branch March 30, 2023 13:56
Murderlon added a commit that referenced this pull request Apr 3, 2023
@Murderlon
Merge branch 'main' of https://github.com/transloadit/uppy.io
866ebd2 
* 'main' of https://github.com/transloadit/uppy.io:
  Fix drag & drop link in quick start (#96)
  Move over migration guide (#95)
  experiment with Merge Queues (#94)
  fix lint error (#93)
  docs: fix typos (#89)
  add docs for the new COMPANION_REDIS_PUBSUB_SCOPE (#88)
  Add @uppy/audio docs (#86)
  Fix vue doc. (#83)
  meta: mark `format:check-diff` on unformatted code as failure (#84)
  uppy-core: prettify (#85)
  Fix locales link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees

@YukeshShr YukeshShr

Labels
uppy The open source file uploader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration guides page link on uppy.io returns a 404
3 participants
@YukeshShr @Murderlon @lekevbot