This repository has been archived by the owner on Apr 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I gave it a quick test locally. Built with yarn. Windows 10 with git bash shell.
Maybe you'll find this helpful. :) |
Great progress. I hope i'll have time to deep dive on it later on this week |
Closed
Closed
sag1v
reviewed
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😳
V2 - Implement eject script
Update Dependencies for v2
Change templates to use hooks
@CarterMcAlister excited to see this get updated -- let me know if you run into any issues 😄 |
I finally got around to updating CRL and releasing This release uses a minor fork of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch separates out the core dependencies and build logic into a
crl-scripts
package in a very similar way thatcreate-react-app
usesreact-scripts
to centralize all logic.This will make upgrading and maintaining most CRL libraries much easier and give CRL more control over the bundling process so we can push incremental changes more frequently.
The goal is to be able to
eject
from usingcrl-scripts
in very much the same way that CRA does, but this functionality is currently missing.This change also updates the example apps to use CRA v2 and is a superset of #134 and #122.
I created one issue for some weird behavior I ran into with CRA v2 and local linking.
cc @paulmelnikow @wuweiweiwu @danielsogl @sag1v @tsiq-swyx would love to hear your guy's thoughts on this direction for CRL v2. Also very much looking for contributors who are interested in helping out with finalizing this PR.
Still TODO:
eject
functionalitycrl-scripts
similar to how CRA and microbundle workFixes #104, #116, #67 (updating the version of rollup), #99, #119,
Thanks!