Bug fix: nested user-interface-wrappers gave JavaScript errors when c…

…trl-alt-M was used to disable then restart all UIs.
trampgeek · Jul 4, 2024 · 155aa78 · 155aa78
1 parent 75c9711
commit 155aa78
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/amd/build/userinterfacewrapper.min.js b/amd/build/userinterfacewrapper.min.js
diff --git a/amd/build/userinterfacewrapper.min.js.map b/amd/build/userinterfacewrapper.min.js.map
diff --git a/amd/src/userinterfacewrapper.js b/amd/src/userinterfacewrapper.js
@@ -225,7 +225,13 @@ define(['jquery', 'core/templates', 'core/notification'], function($, Templates,
                 if (t.uiInstance !== null || t.loadFailed) {
                     t.stop();
                 } else {
-                    t.restart();        // Reactivate
+                    // If the wrapper still exists (which won't be the case for
+                    // userinterfacewrappers embedded within another userinterface wrapper)
+                    // restart the UI within the wrapper.
+                    const wrapper = document.getElementById(`${t.taId}_wrapper`);
+                    if (wrapper) {
+                        t.restart();        // Reactivate
+                    }
                 }
             }
         });

diff --git a/version.php b/version.php
@@ -22,7 +22,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version  = 2024031500;
+$plugin->version  = 2024070500;
 $plugin->requires = 2022041900;
 $plugin->cron = 0;
 $plugin->component = 'qtype_coderunner';