Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/summary comments #428

Merged
merged 10 commits into from
Feb 12, 2025
Merged

Feat/summary comments #428

merged 10 commits into from
Feb 12, 2025

Conversation

seferturan
Copy link
Collaborator

🎶 Notes 🎶

  • Adds the top 10 comments to movie and summary pages
  • Spoilers are dismissible by clicking on them
    • If an entire comment is marked as a spoiler, any individual spoiler tags in the comment are omitted.
    • If the comment itself is not marked as a spoiler, the individual spoiler tags are blurred and clickable.
  • Fixes avatar size in popular lists
  • Will get a follow up to deal with deleted users (applicable to popular lists and comments)

👀 Examples 👀

Screenshot 2025-02-12 at 12 19 35 Screenshot 2025-02-12 at 12 20 20
Screen.Recording.2025-02-12.at.12.19.52.mov

Popular lists avatar change:
Before:
Screenshot 2025-02-12 at 14 50 55

After:
Screenshot 2025-02-12 at 14 50 25

Copy link

deepsource-io bot commented Feb 12, 2025

Here's the code health analysis summary for commits cfa654c..f0d3ef5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateJavascript
Branch Coverage26.6% (down 0.1% from main)26.6% (down 0.1% from main)
Composite Coverage61.2% (down 0.1% from main)61.2% (down 0.1% from main)
Line Coverage73.1%73.1%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@seferturan seferturan requested a review from vladjerca February 12, 2025 14:02
@vladjerca vladjerca force-pushed the feat/summary_comments branch from 9a566f1 to f0d3ef5 Compare February 12, 2025 14:13
@vladjerca vladjerca self-requested a review February 12, 2025 14:13
@seferturan seferturan merged commit d90e150 into main Feb 12, 2025
9 checks passed
@seferturan seferturan deleted the feat/summary_comments branch February 12, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants